Add a dispose method to IJupyterYWidget
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the context, it has been discussed at geojupyter/jupytergis#419 (comment) |
4 tasks
trungleduc
reviewed
Feb 6, 2025
src/notebookrenderer/view.ts
Outdated
| @@ -22,6 +23,7 @@ export class JupyterYWidget extends Widget implements IRenderMime.IRenderer { | |||
| } | |||
|
|
|||
| dispose(): void { | |||
| this._ywidget?.dispose?.(); | |||
There was a problem hiding this comment.
This should be called later, after the this.isDisposed check?
There was a problem hiding this comment.
I first tried after the this._yModel?.dispose(); but it was never reached in our case (jupytergis). I missed the error below.
I'll check if this is related to jupytergis or yjs_widgets.
trungleduc
approved these changes
Feb 6, 2025
|
Thanks! |
|
I don't have the right to merge 😃 |
😄 does somebody has this right ?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call a 'dispose()' method of the widget when the view is disposed (notebook closed or cell output cleared).
cc. @trungleduc