Patch rocThrust gtest build type for Windows compatibility. #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
commented
Apr 7, 2025
Comment on lines
+19
to
+20
| - CMAKE_ARGS -DBUILD_GTEST=ON -DINSTALL_GTEST=ON -Dgtest_force_shared_crt=ON -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX=<INSTALL_DIR> | ||
| + CMAKE_ARGS -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DBUILD_GTEST=ON -DINSTALL_GTEST=ON -Dgtest_force_shared_crt=ON -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX=<INSTALL_DIR> |
There was a problem hiding this comment.
Note that rocThrust already adds this CMake option for googlebenchmark: https://github.com/ROCm/rocThrust/blob/dfb07406c7ecc401e82a05497f99b0ef5aeb13f8/cmake/Dependencies.cmake#L167
download_project(
PROJ googlebenchmark
GIT_REPOSITORY https://github.com/google/benchmark.git
GIT_TAG v${BENCHMARK_VERSION}
GIT_SHALLOW TRUE
INSTALL_DIR ${GOOGLEBENCHMARK_ROOT}
CMAKE_ARGS -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DBUILD_SHARED_LIBS=OFF -DBENCHMARK_ENABLE_TESTING=OFF -DCMAKE_INSTALL_PREFIX=<INSTALL_DIR> -DCMAKE_CXX_STANDARD=14 ${COMPILER_OVERRIDE}
ScottTodd
added a commit
that referenced
this pull request
Apr 7, 2025
Progress on #36. This, together with #358, fixes test compilation for hipCUB and rocThrust. Details: * `-fms-extensions` and `-fms-compatibility` are documented here: https://clang.llvm.org/docs/MSVCCompatibility.html * Projects like hipCUB set `-D_ENABLE_EXTENDED_ALIGNED_STORAGE` to acknowledge using extended aligned storage: https://github.com/ROCm/hipCUB/blob/40f174daf777856949c624317c16ffbfe93e9108/rmake.py#L105-L108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #36.
I was seeing errors like this:
The documentation for
_ITERATOR_DEBUG_LEVELhttps://learn.microsoft.com/en-us/cpp/standard-library/iterator-debug-level?view=msvc-170 suggested that gtest was getting built in Debug while the rest of the project was getting built in Release. There are likely other dependencies affected by this issue, but this was minimally what I needed to build all rocThrust tests on Windows: