Remove jaxlib build #366
Closed
Remove jaxlib build #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleshofer
requested review from
mrodden,
JehandadKhan,
Ruturaj4 and
zahiqbal
mrodden
reviewed
Apr 22, 2025
| @@ -92,7 +92,7 @@ RUN --mount=type=cache,mode=0755,target=/root/.cache/pip \ | |||
| --mount=type=bind,source=wheelhouse,target=/wheelhouse \ | |||
| cp /wheelhouse/* /rocm_jax_wheels/ && \ | |||
| ls -lah /wheelhouse && \ | |||
| pip3 install wheelhouse/*none*.whl wheelhouse/*jaxlib*.whl && \ | |||
There was a problem hiding this comment.
You'll need to install some jaxlib wheel if you don't install the one we are building.
Also you'll be installing the jax wheel with none I think still, which is built in build_jax_wheel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't needed to build the jaxlib wheel since 0.4.35. All code for AMD GPUs should be a part of the plugin wheels,
jax-rocm-pluginandjax-rocm-pjrt. Remove thejaxlibwheel from the build.