Skip to content

Remove jaxlib build #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Remove jaxlib build #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
025346e
Remove jaxlib build
charleshofer Apr 15, 2025
8d47f3c
Change function name
charleshofer Apr 15, 2025
942be94
Remove jaxlib from Docker image build
charleshofer Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/rocm/Dockerfile.ms
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ RUN --mount=type=cache,mode=0755,target=/root/.cache/pip \
--mount=type=bind,source=wheelhouse,target=/wheelhouse \
cp /wheelhouse/* /rocm_jax_wheels/ && \
ls -lah /wheelhouse && \
pip3 install wheelhouse/*none*.whl wheelhouse/*jaxlib*.whl && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to install some jaxlib wheel if you don't install the one we are building.

Also you'll be installing the jax wheel with none I think still, which is built in build_jax_wheel

pip3 install wheelhouse/*none*.whl && \
pip3 install wheelhouse/*rocm60*.whl


6 changes: 3 additions & 3 deletions build/rocm/tools/build_wheels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def find_clang_path():
return None


def build_jaxlib_wheel(
def build_plugin_wheels(
jax_path, rocm_path, python_version, xla_path=None, compiler="gcc"
):
use_clang = "true" if compiler == "clang" else "false"
Expand All @@ -105,7 +105,7 @@ def build_jaxlib_wheel(
"python",
"build/build.py",
"build",
"--wheels=jaxlib,jax-rocm-plugin,jax-rocm-pjrt",
"--wheels=jax-rocm-plugin,jax-rocm-pjrt",
"--rocm_path=%s" % rocm_path,
"--rocm_version=60",
"--use_clang=%s" % use_clang,
Expand Down Expand Up @@ -298,7 +298,7 @@ def main():
update_rocm_targets(rocm_path, GPU_DEVICE_TARGETS)

for py in python_versions:
build_jaxlib_wheel(args.jax_path, rocm_path, py, args.xla_path, args.compiler)
build_plugin_wheels(args.jax_path, rocm_path, py, args.xla_path, args.compiler)
wheel_paths = find_wheels(os.path.join(args.jax_path, "dist"))
for wheel_path in wheel_paths:
# skip jax wheel since it is non-platform
Expand Down
Loading