fix: integrate handleChatCompletion to save chat memories #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
handleChatCompletionintohandleChatStreamandhandleChatGenerateto properly save chat memoriesRoot Cause
The
handleChatCompletionfunction atlib/chat/handleChatCompletion.tswas implemented with:upsertMemoryHowever, both
handleChatStream.tsandhandleChatGenerate.tshad TODO comments but never actually called the function:Changes
handleChatCompletioncall inhandleChatStream.tsafter streaming completeshandleChatCompletioncall inhandleChatGenerate.tsafter text generationTest plan
handleChatCompletionis called with correct parameters🤖 Generated with Claude Code