Skip to content

fix: integrate handleChatCompletion to save chat memories #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sweetmantech merged 4 commits into from
Jan 16, 2026
Merged

fix: integrate handleChatCompletion to save chat memories #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7ef0b8
fix: integrate handleChatCompletion to save chat memories
sweetmantech Jan 16, 2026
2379787
fix: construct UIMessage from generateText result for type compatibility
sweetmantech Jan 16, 2026
b9aab83
fix: remove createdAt property not in UIMessage type
sweetmantech Jan 16, 2026
e3f6b10
fix: construct UIMessage from stream result.text instead of responseM…
sweetmantech Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
223 changes: 189 additions & 34 deletions lib/chat/__tests__/handleChatGenerate.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
import { NextResponse } from "next/server";

import { getApiKeyAccountId } from "@/lib/auth/getApiKeyAccountId";
import { validateOverrideAccountId } from "@/lib/accounts/validateOverrideAccountId";
import { setupChatRequest } from "@/lib/chat/setupChatRequest";
import { handleChatCompletion } from "@/lib/chat/handleChatCompletion";
import { generateText } from "ai";
import { handleChatGenerate } from "../handleChatGenerate";

// Mock all dependencies before importing the module under test
vi.mock("@/lib/auth/getApiKeyAccountId", () => ({
getApiKeyAccountId: vi.fn(),
Expand All @@ -26,26 +33,27 @@ vi.mock("@/lib/chat/setupChatRequest", () => ({
setupChatRequest: vi.fn(),
}));

vi.mock("@/lib/chat/handleChatCompletion", () => ({
handleChatCompletion: vi.fn(),
}));

vi.mock("ai", () => ({
generateText: vi.fn(),
}));

import { getApiKeyAccountId } from "@/lib/auth/getApiKeyAccountId";
import { validateOverrideAccountId } from "@/lib/accounts/validateOverrideAccountId";
import { setupChatRequest } from "@/lib/chat/setupChatRequest";
import { generateText } from "ai";
import { handleChatGenerate } from "../handleChatGenerate";

const mockGetApiKeyAccountId = vi.mocked(getApiKeyAccountId);
const mockValidateOverrideAccountId = vi.mocked(validateOverrideAccountId);
const mockSetupChatRequest = vi.mocked(setupChatRequest);
const mockHandleChatCompletion = vi.mocked(handleChatCompletion);
const mockGenerateText = vi.mocked(generateText);

// Helper to create mock NextRequest
function createMockRequest(
body: unknown,
headers: Record<string, string> = {},
): Request {
/**
*
* @param body
* @param headers
*/
function createMockRequest(body: unknown, headers: Record<string, string> = {}): Request {
return {
json: () => Promise.resolve(body),
headers: {
Expand All @@ -58,6 +66,8 @@ function createMockRequest(
describe("handleChatGenerate", () => {
beforeEach(() => {
vi.clearAllMocks();
// Default mock for handleChatCompletion to return a resolved Promise
mockHandleChatCompletion.mockResolvedValue();
});

afterEach(() => {
Expand All @@ -68,10 +78,7 @@ describe("handleChatGenerate", () => {
it("returns 400 error when neither messages nor prompt is provided", async () => {
mockGetApiKeyAccountId.mockResolvedValue("account-123");

const request = createMockRequest(
{ roomId: "room-123" },
{ "x-api-key": "test-key" },
);
const request = createMockRequest({ roomId: "room-123" }, { "x-api-key": "test-key" });

const result = await handleChatGenerate(request as any);

Expand Down Expand Up @@ -122,10 +129,7 @@ describe("handleChatGenerate", () => {
},
} as any);

const request = createMockRequest(
{ prompt: "Hello, world!" },
{ "x-api-key": "valid-key" },
);
const request = createMockRequest({ prompt: "Hello, world!" }, { "x-api-key": "valid-key" });

const result = await handleChatGenerate(request as any);

Expand Down Expand Up @@ -157,10 +161,7 @@ describe("handleChatGenerate", () => {
} as any);

const messages = [{ role: "user", content: "Hello" }];
const request = createMockRequest(
{ messages },
{ "x-api-key": "valid-key" },
);
const request = createMockRequest({ messages }, { "x-api-key": "valid-key" });

await handleChatGenerate(request as any);

Expand Down Expand Up @@ -237,10 +238,7 @@ describe("handleChatGenerate", () => {
response: { messages: [], headers: {}, body: null },
} as any);

const request = createMockRequest(
{ prompt: "Hello" },
{ "x-api-key": "valid-key" },
);
const request = createMockRequest({ prompt: "Hello" }, { "x-api-key": "valid-key" });

const result = await handleChatGenerate(request as any);

Expand All @@ -256,10 +254,7 @@ describe("handleChatGenerate", () => {
mockGetApiKeyAccountId.mockResolvedValue("account-123");
mockSetupChatRequest.mockRejectedValue(new Error("Setup failed"));

const request = createMockRequest(
{ prompt: "Hello" },
{ "x-api-key": "valid-key" },
);
const request = createMockRequest({ prompt: "Hello" }, { "x-api-key": "valid-key" });

const result = await handleChatGenerate(request as any);

Expand All @@ -284,10 +279,7 @@ describe("handleChatGenerate", () => {

mockGenerateText.mockRejectedValue(new Error("Generation failed"));

const request = createMockRequest(
{ prompt: "Hello" },
{ "x-api-key": "valid-key" },
);
const request = createMockRequest({ prompt: "Hello" }, { "x-api-key": "valid-key" });

const result = await handleChatGenerate(request as any);

Expand Down Expand Up @@ -336,4 +328,167 @@ describe("handleChatGenerate", () => {
);
});
});

describe("chat completion handling", () => {
it("calls handleChatCompletion after text generation", async () => {
mockGetApiKeyAccountId.mockResolvedValue("account-123");

mockSetupChatRequest.mockResolvedValue({
model: "gpt-4",
instructions: "test",
system: "test",
messages: [],
experimental_generateMessageId: vi.fn(),
tools: {},
providerOptions: {},
} as any);

mockGenerateText.mockResolvedValue({
text: "Hello!",
finishReason: "stop",
usage: { promptTokens: 10, completionTokens: 20 },
response: { messages: [], headers: {}, body: null },
} as any);

mockHandleChatCompletion.mockResolvedValue();

const messages = [{ id: "msg-1", role: "user", parts: [{ type: "text", text: "Hi" }] }];
const request = createMockRequest(
{ messages, roomId: "room-123" },
{ "x-api-key": "valid-key" },
);

await handleChatGenerate(request as any);

expect(mockHandleChatCompletion).toHaveBeenCalledWith(
expect.objectContaining({
messages,
roomId: "room-123",
accountId: "account-123",
}),
expect.arrayContaining([
expect.objectContaining({
role: "assistant",
parts: [{ type: "text", text: "Hello!" }],
}),
]),
);
});

it("passes artistId to handleChatCompletion when provided", async () => {
mockGetApiKeyAccountId.mockResolvedValue("account-123");

mockSetupChatRequest.mockResolvedValue({
model: "gpt-4",
instructions: "test",
system: "test",
messages: [],
experimental_generateMessageId: vi.fn(),
tools: {},
providerOptions: {},
} as any);

mockGenerateText.mockResolvedValue({
text: "Hello!",
finishReason: "stop",
usage: { promptTokens: 10, completionTokens: 20 },
response: { messages: [], headers: {}, body: null },
} as any);

mockHandleChatCompletion.mockResolvedValue();

const messages = [{ id: "msg-1", role: "user", parts: [{ type: "text", text: "Hi" }] }];
const request = createMockRequest(
{ messages, roomId: "room-123", artistId: "artist-456" },
{ "x-api-key": "valid-key" },
);

await handleChatGenerate(request as any);

expect(mockHandleChatCompletion).toHaveBeenCalledWith(
expect.objectContaining({
artistId: "artist-456",
}),
expect.arrayContaining([
expect.objectContaining({
role: "assistant",
parts: [{ type: "text", text: "Hello!" }],
}),
]),
);
});

it("does not throw when handleChatCompletion fails (graceful handling)", async () => {
mockGetApiKeyAccountId.mockResolvedValue("account-123");

mockSetupChatRequest.mockResolvedValue({
model: "gpt-4",
instructions: "test",
system: "test",
messages: [],
experimental_generateMessageId: vi.fn(),
tools: {},
providerOptions: {},
} as any);

mockGenerateText.mockResolvedValue({
text: "Hello!",
finishReason: "stop",
usage: { promptTokens: 10, completionTokens: 20 },
response: {
messages: [{ id: "resp-1", role: "assistant", parts: [] }],
headers: {},
body: null,
},
} as any);

// Make handleChatCompletion throw an error
mockHandleChatCompletion.mockRejectedValue(new Error("Completion handling failed"));

const request = createMockRequest({ prompt: "Hello" }, { "x-api-key": "valid-key" });

// Should still return 200 - completion handling failure should not affect response
const result = await handleChatGenerate(request as any);
expect(result.status).toBe(200);
});

it("calls handleChatCompletion even when validation skips it for missing roomId", async () => {
mockGetApiKeyAccountId.mockResolvedValue("account-123");

const mockResponseMessages = [
{
id: "resp-1",
role: "assistant",
parts: [{ type: "text", text: "Hello!" }],
},
];

mockSetupChatRequest.mockResolvedValue({
model: "gpt-4",
instructions: "test",
system: "test",
messages: [],
experimental_generateMessageId: vi.fn(),
tools: {},
providerOptions: {},
} as any);

mockGenerateText.mockResolvedValue({
text: "Hello!",
finishReason: "stop",
usage: { promptTokens: 10, completionTokens: 20 },
response: { messages: mockResponseMessages, headers: {}, body: null },
} as any);

mockHandleChatCompletion.mockResolvedValue();

// No roomId provided
const request = createMockRequest({ prompt: "Hello" }, { "x-api-key": "valid-key" });

await handleChatGenerate(request as any);

// handleChatCompletion should still be called (it handles room creation internally)
expect(mockHandleChatCompletion).toHaveBeenCalled();
});
});
});
Loading