Improve Managed Runtime Feedback and Cross-Platform Validation - #71
Conversation
|
Warning Review limit reached
Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe project version is advanced from Sequence Diagram(s)sequenceDiagram
participant CLI
participant ManagedRuntime
participant Gateway
participant WebUI
CLI->>ManagedRuntime: Launch selected artifact with runtime identity
ManagedRuntime-->>Gateway: Expose active artifact state
Gateway-->>WebUI: Return active and selected model flags
WebUI-->>WebUI: Render running or restart-required status
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deploy/tests/native_installer_real_smoke.sh`:
- Around line 58-68: Update cleanup_services to guard web_pid with the same
non-empty check used for jupyter_pid before calling kill and wait, then invoke
the existing cleanup function at the end so the temporary workspace is removed
when the EXIT trap runs.
In `@packages/adapters/tests/test_conformance.py`:
- Around line 119-124: Update the conformance test around verify_skill and
assert_registry_adapter_conforms so the verification result itself is checked,
not only verification.reason. Add a direct assertion that verification.verified
is true, or incorporate that assertion into the helper while preserving the
existing reason validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 482d36b5-5649-4290-a8f8-1964a21541de
⛔ Files ignored due to path filters (2)
packages/webui/package-lock.jsonis excluded by!**/package-lock.jsonuv.lockis excluded by!**/*.lock
📒 Files selected for processing (68)
README.mdVERSION.tomldeploy/tests/native_installer_real_smoke.shdocker-bake.hcldocumentation/contribute/releases.mddocumentation/models/offline.mddocumentation/platforms/carina.mddocumentation/platforms/containers.mddocumentation/platforms/native-linux.mddocumentation/platforms/terra.mddocumentation/use/notebooks.mdfixtures/synthetic/skills/omop-cohort-summary/SKILL.mdfixtures/synthetic/skills/omop-cohort-summary/metadata.jsonimages/generic/local-runtime/snapshots.tomlpackages/adapters/pyproject.tomlpackages/adapters/src/heartwood/adapters/__init__.pypackages/adapters/src/heartwood/adapters/conformance.pypackages/adapters/tests/test_conformance.pypackages/audit/pyproject.tomlpackages/audit/src/heartwood/audit/__init__.pypackages/cli/pyproject.tomlpackages/cli/src/heartwood/cli/__init__.pypackages/cli/src/heartwood/cli/_launch.pypackages/cli/tests/test_cli.pypackages/cli/tests/test_launch.pypackages/compliance/pyproject.tomlpackages/compliance/src/heartwood/compliance/__init__.pypackages/compliance/tests/test_container_assets.pypackages/compliance/tests/test_release_governance.pypackages/core-adapter/pyproject.tomlpackages/core-adapter/src/heartwood/core_adapter/__init__.pypackages/detector/pyproject.tomlpackages/detector/src/heartwood/detector/__init__.pypackages/fixtures/pyproject.tomlpackages/fixtures/src/heartwood/fixtures/__init__.pypackages/gateway/pyproject.tomlpackages/gateway/src/heartwood/gateway/_gateway.pypackages/gateway/src/heartwood/gateway/_project_file_editor.pypackages/gateway/src/heartwood/gateway/_readiness.pypackages/gateway/tests/test_gateway_contract.pypackages/gateway/tests/test_local_models.pypackages/gateway/tests/test_model_snapshots.pypackages/gateway/tests/test_project_file_editor.pypackages/gateway/tests/test_readiness.pypackages/model-policy/pyproject.tomlpackages/model-policy/src/heartwood/model_policy/__init__.pypackages/notebook/pyproject.tomlpackages/notebook/src/heartwood/notebook/__init__.pypackages/schemas/pyproject.tomlpackages/schemas/src/heartwood/schemas/__init__.pypackages/schemas/tests/test_schema_records.pypackages/session/pyproject.tomlpackages/session/src/heartwood/session/__init__.pypackages/skills/pyproject.tomlpackages/webui/package.jsonpackages/webui/src/App.test.tsxpackages/webui/src/client.test.tspackages/webui/src/components/UtilitySheet.tsxpackages/webui/src/e2e/app.spec.tspackages/webui/src/types.tspackages/webui/src/viewModel.test.tspackages/webui/src/viewModel.tsskills/verified/aggregate-export/SKILL.mdskills/verified/aggregate-export/metadata.jsonskills/verified/baseline-model/SKILL.mdskills/verified/baseline-model/metadata.jsonskills/verified/omop-cohort-summary/SKILL.mdskills/verified/omop-cohort-summary/metadata.json
♻️ Current Situation & Problem
Live beta 4 validation on native Linux, the standard container, Terra, and Carina identified gaps in runtime identity, model guidance, tool paths, approval feedback, setup progress, and platform instructions.
Advances #25, #42, and #51.
⚙️ Release Notes
0.2.0-beta.5.📚 Documentation
✅ Testing
Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: