-
Notifications
You must be signed in to change notification settings - Fork 17
1277 Quarantine Effectiveness #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1282 +/- ##
==========================================
+ Coverage 97.28% 97.30% +0.02%
==========================================
Files 168 168
Lines 14858 14867 +9
==========================================
+ Hits 14454 14466 +12
+ Misses 404 401 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only two super small changes requested.
@@ -530,6 +530,21 @@ struct QuarantineDuration { | |||
} | |||
}; | |||
|
|||
/** | |||
* @brief Effectiveness of quarantine. 0.0 meaning no effect (precentual reduction of viral shed emmition), 1.0 meaning full effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @brief Effectiveness of quarantine. 0.0 meaning no effect (precentual reduction of viral shed emmition), 1.0 meaning full effect. | |
* @brief Effectiveness of quarantine. 0.0 meaning no effect (percentage reduction of viral shed emission), 1.0 meaning full effect. |
EXPECT_TRUE(params.check_constraints()); | ||
params.get<mio::abm::QuarantineEffectiveness>() = 1.5; | ||
EXPECT_TRUE(params.check_constraints()); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be set to a valid value after the checks.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)