-
Notifications
You must be signed in to change notification settings - Fork 17
1277 Quarantine Effectiveness #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xsaschako
wants to merge
10
commits into
main
Choose a base branch
from
1277-quarantine-effectiveness
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
16998f3
Add QuarantineEffectiveness struct and validation check
xsaschako e92d880
add parameter
xsaschako eb4c21b
Add quarantine effectiveness and duration parameters to constraint ch…
xsaschako 0be39c4
Enhance model function
xsaschako c22a46e
Merge branch 'main' into 1277-quarantine-effectiveness
xsaschako e5f8198
changes
xsaschako 0efd2cb
fix bug
xsaschako 6ece3fe
fix surr bug
xsaschako 057eb03
add UseLocationCapacityForTransmissions for coverage
xsaschako 8140703
Merge branch 'main' into 1277-quarantine-effectiveness
xsaschako File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -691,6 +691,8 @@ TEST_F(TestModel, checkParameterConstraints) | |
params.get<mio::abm::MaskProtection>()[mio::abm::MaskType::Community] = 0.5; | ||
params.get<mio::abm::MaskProtection>()[mio::abm::MaskType::FFP2] = 0.6; | ||
params.get<mio::abm::MaskProtection>()[mio::abm::MaskType::Surgical] = 0.7; | ||
params.get<mio::abm::QuarantineEffectiveness>() = 0.5; | ||
params.get<mio::abm::QuarantineDuration>() = mio::abm::days(14); | ||
params.get<mio::abm::LockdownDate>() = mio::abm::TimePoint(0); | ||
ASSERT_EQ(params.check_constraints(), false); | ||
|
||
|
@@ -789,6 +791,11 @@ TEST_F(TestModel, checkParameterConstraints) | |
EXPECT_TRUE(params.check_constraints()); | ||
params.get<mio::abm::MaskProtection>()[mio::abm::MaskType::Surgical] = 0.7; | ||
|
||
params.get<mio::abm::QuarantineEffectiveness>() = -0.1; | ||
EXPECT_TRUE(params.check_constraints()); | ||
params.get<mio::abm::QuarantineEffectiveness>() = 1.5; | ||
EXPECT_TRUE(params.check_constraints()); | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be set to a valid value after the checks. |
||
params.get<mio::abm::LockdownDate>() = mio::abm::TimePoint(-2); | ||
EXPECT_TRUE(params.check_constraints()); | ||
mio::set_log_level(mio::LogLevel::warn); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.