add alternating row colors for better readability to geneds table (#227)#236
add alternating row colors for better readability to geneds table (#227)#236maelleallanic wants to merge 4 commits intoScottyLabs:mainfrom
Conversation
|
@maelleallanic is attempting to deploy a commit to the ScottyLabs Team on Vercel. A member of the Team first needs to authorize it. |
top 3 for sure kidding |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
apps/frontend/src/components/GenedsDataTable.tsx:159
- Consider using strict equality (===) to ensure type-safe comparisons.
const bgColor = idx % 2 == 0 ? "bg-white" : "bg-gray-50";
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| {table.getRowModel().rows.map((row,idx) => { | ||
| const bgColor = idx % 2 == 0 ? "bg-white" : "bg-gray-50"; | ||
| return ( | ||
| <tr key={row.id} className={`${bgColor} hover:bg-gray-100 dark:hover:bg-gray-200`}> |
There was a problem hiding this comment.
This would benefit from some margin outside the inner text in each row, or some padding within each row. It'll make the gened table look less cramped.
Otherwise I think it looks great
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
apps/frontend/src/components/GenedsDataTable.tsx:159
- [nitpick] Consider using the strict equality operator (===) instead of (==) for better clarity and to prevent potential type coercion issues.
const bgColor = idx % 2 == 0 ? "bg-white" : "bg-gray-50";
|
I'm not sure I really vibe with the light mode. I can see where this is going with the dark mode, but this currently isn't consistent with the other tables in the course search page |
|
not a fan of how this looks. I think opaque horiz lines will look better. |
Closes #227
adds alternating background colors to the geneds table rows to improve readability and visual scanning
lowkey not super happy with the colors in light mode, i wanted the hover to be lighter than the rows
anish am i ur fav slabs parent yet