Skip to content

add alternating row colors for better readability to geneds table (#227) #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
maelleallanic wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

add alternating row colors for better readability to geneds table (#227) #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e77fc4b
add alternating row colors for better readability
maelleallanic Apr 7, 2025
8952cb2
add fall 2025 semester session filter (#237)
maelleallanic Apr 7, 2025
c3a685b
Merge branch 'feature/striped-rows' of https://github.com/maelleallan…
maelleallanic Apr 8, 2025
5c76d18
add padding in table rows for better readability
maelleallanic Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions apps/frontend/src/components/GenedsDataTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,18 +155,21 @@ export const GenedsDataTable = ({ data }: { data: Gened[] }) => {
))}
</thead>
<tbody>
{table.getRowModel().rows.map((row) => (
<tr key={row.id} className="hover:bg-white">
{row.getVisibleCells().map((cell) => (
<td
className="whitespace-nowrap px-2 text-sm text-gray-600"
key={cell.id}
>
{flexRender(cell.column.columnDef.cell, cell.getContext())}
</td>
))}
</tr>
))}
{table.getRowModel().rows.map((row,idx) => {
const bgColor = idx % 2 == 0 ? "bg-white" : "bg-gray-50";
return (
<tr key={row.id} className={`${bgColor} hover:bg-gray-100 dark:hover:bg-gray-200`}>
Copy link
Copy Markdown
Contributor

@ap-1 ap-1 Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would benefit from some margin outside the inner text in each row, or some padding within each row. It'll make the gened table look less cramped.

Otherwise I think it looks great

{row.getVisibleCells().map((cell) => (
<td
className="whitespace-nowrap px-3 py-1 text-sm text-gray-600"
key={cell.id}
>
{flexRender(cell.column.columnDef.cell, cell.getContext())}
</td>
))}
</tr>
);
})}
</tbody>
</table>
);
Expand Down
1 change: 1 addition & 0 deletions apps/frontend/src/components/filters/SemestersOfferedFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { Session } from "~/app/types";
import { classNames, sessionToShortString, sessionToString } from "~/app/utils";

const SESSIONS: Session[] = [
{ year: "2025", semester: "fall" },
{ year: "2025", semester: "summer" },
{ year: "2025", semester: "spring" },
{ year: "2024", semester: "fall" },
Expand Down
Loading