fix: tx->TxEnv conversion drops fields#42
Open
samlaf wants to merge 2 commits intoveridise-audit-feb-2026from
Open
fix: tx->TxEnv conversion drops fields#42samlaf wants to merge 2 commits intoveridise-audit-feb-2026from
samlaf wants to merge 2 commits intoveridise-audit-feb-2026from
Conversation
samlaf
added a commit
to SeismicSystems/seismic-reth
that referenced
this pull request
Mar 25, 2026
…recovered_tx (#349) Same fix as that from SeismicSystems/seismic-evm#42 Not sure if there was an issue here, but its just unnecessary duplicate code that is likely to contain a bug like it did in evm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes veridise-902.
The implementation of FromRecoveredTx was (badly) reimplementing the conversion that already exists in TxEnv::from_recovered_tx and dropping fields.
Added a TxEnv::from_recovered_tx implementation for TxSeismic, and then updated FromRecoveredTx to delegate ot from_recovered_tx.
Note
The code had a comment saying this function is only used for testing:
However Claude analyzed its actual usage and found that its used in production. Updated the comments to mention that its used in
SeismicAlloyReceiptBuilder.