[NV] minimax-m3-B300-dynamo: use vLLM nightly image / [NV] minimax-m3-B300-dynamo:使用 vLLM nightly 镜像 - #2338
Conversation
…96 tep4 arm for 3p2d-dep2-dep8 minimaxm3-fp8-b300-dynamo-vllm: - image -> vllm/vllm-openai:nightly-4080263bb2c5d10deac17aaeb88e0823bc35bca9 - dynamo -> 1.3.0.dev20260710 (recipe files) - drop minimax-m3-vllm-fixes.sh setup patch + launcher wiring (shipped in the nightly image) - conc 4096: drop 4p2d-dep2-tep4 arm; add 3p2d-dep2-dep8 for conc [1024, 2048] (prefill 3xDEP2, decode 2xDEP8)
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
There was a problem hiding this comment.
LGTM — this is a mechanical nightly image/dynamo version bump plus a topology arm swap for the minimax-m3 B300 disaggregated sweep, consistent with the established recipe/master-config pattern. The two inline nits (stale router.version metadata and missing bilingual PR title/description) are process/provenance-only and don't affect what actually gets deployed or benchmarked, so they shouldn't block merge.
Extended reasoning...
Overview
The PR bumps the vLLM nightly image and dynamo version across all 8 minimaxm3-fp8-b300-dynamo-vllm recipe YAMLs, drops the now-unneeded minimax-m3-vllm-fixes.sh runtime patch (and its launcher wiring in runners/launch_b300-nv.sh) since the fix is now shipped in the nightly image, and reworks the conc-4096 arm of the topology search space in configs/nvidia-master.yaml — replacing 4p2d-dep2-tep4 with a new 3p2d-dep2-dep8 arm covering conc [1024, 2048]. A matching perf-changelog.yaml entry documents the change. All edits follow the same mechanical pattern already established elsewhere in the repo (image bump + dynamo version bump + resources/vllm_config rework for a new topology arm).
Security risks
None. This only touches benchmark recipe YAML, a Slurm launcher shell script, and changelog/master-config metadata — no auth, crypto, secrets, or user-facing code paths are involved. The image reference is a pinned nightly tag (not a mutable/latest tag), and the dropped setup script removes a Python monkey-patch rather than adding one, which reduces attack surface if anything.
Level of scrutiny
Low-to-moderate. This is a routine recipe maintenance PR of a kind that's merged frequently in this repo (nightly bumps, topology arm swaps). It doesn't touch CODEOWNER-restricted core infra logic, and the changes are self-contained to one model's benchmark configuration. The two findings from the bug-hunting pass are both metadata/process nits (stale router.version string in the master config, and the repo-wide bilingual PR title/description convention) rather than functional bugs — they don't affect what gets deployed, installed, or benchmarked at runtime.
Other factors
The renamed/reworked 3p2d-dep2-dep8-8k1k.yaml arm's resource fields (prefill_workers: 3, decode_workers: 2, gpus_per_decode: 8) and vllm_config (decode data-parallel-size: 8) are internally consistent with the nvidia-master.yaml search-space entry (num-worker: 3/tp: 2/ep: 2 prefill, num-worker: 2/tp: 8/ep: 8/dp-attn: true decode), and mirror the pattern used by the sibling 4p2d-dep2-dep8 arm added previously. No CI/test coverage gaps stand out beyond the existing full-sweep validation gate, which is the mechanism this repo already relies on to catch functional recipe issues.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=30208342156 |
|
/reuse-sweep-run |
|
As a PR reviewer and CODEOWNER, I have reviewed this and have:
Additional detail section:
Signed: |
✅✅✅ Verdict: PASS ✅✅✅✅ Check 0 (CODEOWNER): PASS — |
|
/reuse-sweep-run |
# Conflicts: # perf-changelog.yaml
✅✅✅ Verdict: PASS ✅✅✅✅ Check 0 (CODEOWNER): PASS — |
Summary
B300 disaggregated (
minimaxm3-fp8-b300-dynamo-vllm):vllm/vllm-openai:nightly-4080263bb2c5d10deac17aaeb88e0823bc35bca9and dynamo to1.3.0.dev20260710minimax-m3-vllm-fixes.shsetup patch and its launcher wiring — the fix ships in the nightly image4p2d-dep2-tep4-8k1k.yamlarm; add a new3p2d-dep2-dep8-8k1k.yamlarm for conc[1024, 2048](prefill 3×DEP2, decode 2×DEP8)中文说明
B300 分离式推理配置(
minimaxm3-fp8-b300-dynamo-vllm):vllm/vllm-openai:nightly-4080263bb2c5d10deac17aaeb88e0823bc35bca9,并将 Dynamo 升级到1.3.0.dev20260710minimax-m3-vllm-fixes.sh设置补丁及其启动器接入逻辑,因为该修复已包含在 nightly 镜像中4p2d-dep2-tep4-8k1k.yaml分支;新增3p2d-dep2-dep8-8k1k.yaml分支,用于并发[1024, 2048](预填充侧使用 3 个 DEP2 worker,解码侧使用 2 个 DEP8 worker)