Skip to content

Minimax M3 disagg - #687

Open
faradawn wants to merge 3 commits into
vllm-project:mainfrom
faradawn:minimax-m3-nvfp4-disagg-b300
Open

Minimax M3 disagg#687
faradawn wants to merge 3 commits into
vllm-project:mainfrom
faradawn:minimax-m3-nvfp4-disagg-b300

Conversation

@faradawn

@faradawn faradawn commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Set backend FLASHINFER, use_trtllm_attention, and indexer_kv_dtype fp8 in the attention config for MiniMax-M3 pd_cluster (disaggregated P/D) serving on Blackwell (B200/B300/GB200/GB300). Based on SemiAnalysisAI/InferenceX#2230, SemiAnalysisAI/InferenceX#2310, SemiAnalysisAI/InferenceX#2338, SemiAnalysisAI/InferenceX#2339, and SemiAnalysisAI/InferenceX#2340.

Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
vllm-recipes Ready Ready Preview, Comment Jul 27, 2026 10:54pm

Request Review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds strategy overrides for the pd_cluster on blackwell hardware in models/MiniMaxAI/MiniMax-M3.yaml. A review comment correctly identifies that the command-line arguments in extra_args use underscores instead of hyphens, which will cause unrecognized argument errors in vLLM, and provides a suggestion to fix them.

Comment on lines +208 to +213
- "--attention_config.backend"
- "FLASHINFER"
- "--attention_config.use_trtllm_attention"
- "true"
- "--attention_config.indexer_kv_dtype"
- "fp8"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Command-line arguments in vLLM use hyphens (-) rather than underscores (_) for parameter names. Using underscores like --attention_config.backend will result in an unrecognized argument error when launching the server. They should be updated to use hyphens, matching the standard CLI convention used throughout the rest of this configuration file.

          - "--attention-config.backend"
          - "FLASHINFER"
          - "--attention-config.use-trtllm-attention"
          - "true"
          - "--attention-config.indexer-kv-dtype"
          - "fp8"

@faradawn faradawn changed the title Add FLASHINFER attention config to MiniMax-M3 NVFP4 disaggregated serving on Blackwell MiniMax-M3 disagg B300 NVFP4 Jul 27, 2026
Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant