Skip to content

UI Action - Send Notification to assigned user #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

shridk
Copy link
Contributor

@shridk shridk commented Oct 1, 2024

UI Action - Send Notification to assigned user

This UI Action adds a button that, when clicked, sends an email to the assigned user.
This is Server side script and creates a record in the table 'sys_email' with Email Body, Email Subject and Email Recipients.

When clicked on the form button, it will send notification to the assigned user

shridk added 2 commits October 1, 2024 15:59
UI Action - Send Notification to assigned user
Server Side Script
readme file
@shridk
Copy link
Contributor Author

shridk commented Oct 1, 2024

UI Action - Send Notification to assigned user

@SapphicFire SapphicFire self-assigned this Oct 1, 2024
Copy link
Contributor

@SapphicFire SapphicFire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. However, it doesn’t comply with our contributing guidelines. As a reminder, the general requirements (as outlined in the CONTRIBUTING.md file) are the following: follow the folder+subfolder guidelines and include a readme.md file explaining what the code snippet does. Review your contribution against the guidelines and make the necessary adjustments. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs to be a markdown record: readme.md

I'd also suggest giving additional advice on how to create the UI Action

Comment on lines +5 to +8
gr_sys_email.type = 'send-ready';
gr_sys_email.subject = 'UI Action Notification from Incident ' + current.number;
gr_sys_email.recipients = current.assigned_to.email;
gr_sys_email.body = 'As the incident ' + current.number + ' is assigned to you, this UI Action Notification has been sent. Please review the incident.';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest updating to use the setter and getter methods

gr_sys_email.setValue('field_name', value);
current.getValue('field_name');

This avoids type casting

@SapphicFire SapphicFire closed this Oct 1, 2024
@shridk shridk deleted the patch-1 branch October 5, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants