Skip to content

Add production-mode flag to app dev command #5694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zzooeeyy
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

zzooeeyy commented Apr 23, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented Apr 23, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.68% 9481/12365
🟡 Branches 71.79% 4654/6483
🟡 Functions 76.45% 2457/3214
🟡 Lines 77.22% 8967/11613

Test suite run success

2205 tests passing in 959 suites.

Report generated by 🧪jest coverage report action from d1590d8

- Added `--production-mode` flag to `shopify app dev` command with default false
- Updated `DevSessionOptions` and `DevSessionPayload` interfaces to include `productionMode` parameter
- Added `productionMode` parameter to GraphQL dev session create/update mutations
- Modified all related interfaces and classes to pass the flag through the API chain
- Updated `DevSessionDelete` signature to omit both `assetsUrl` and `productionMode`

Co-authored-by: Ryan DJ Lee <[email protected]>
@zzooeeyy zzooeeyy changed the base branch from zl/no_action_required_for_scope_update to graphite-base/5694 April 23, 2025 20:16
@zzooeeyy zzooeeyy force-pushed the graphite-base/5694 branch from 7a0ae1c to dc440ad Compare April 23, 2025 20:16
@zzooeeyy zzooeeyy force-pushed the add-production-mode-flag branch from fb1d50a to d1590d8 Compare April 23, 2025 20:16
@zzooeeyy zzooeeyy changed the base branch from graphite-base/5694 to main April 23, 2025 20:17
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/array.d.ts
@@ -45,17 +45,4 @@ export declare function uniqBy<T>(array: List<T> | null | undefined, iteratee: V
  * @param values - The arrays of values to exclude.
  * @returns Returns the new array of filtered values.
  */
-export declare function difference<T>(array: List<T> | null | undefined, ...values: List<T>[]): T[];
-/**
- * Converts an array of anything into a human friendly list.
- *
- * Returns a new array that contains the items separated by commas,
- * except for the last item, which is separated by "and".
- * This is useful for creating human-friendly sentences.
- *
- * @param items - Token[].
- * @returns Token[].
- * @example
- * 
- */
-export declare function asHumanFriendlyArray<T>(items: T[]): (T | string)[];
\ No newline at end of file
+export declare function difference<T>(array: List<T> | null | undefined, ...values: List<T>[]): T[];
\ No newline at end of file
packages/cli-kit/dist/public/node/api/business-platform.d.ts
@@ -40,6 +40,6 @@ export declare function businessPlatformOrganizationsRequest<T>(query: string, t
  * @param variables - GraphQL variables to pass to the query.
  * @returns The response of the query of generic type <T>.
  */
-export declare function businessPlatformOrganizationsRequestDoc<TResult, TVariables extends Variables>(query: TypedDocumentNode<TResult, TVariables> | TypedDocumentNode<TResult, Exact<{
+export declare function businessPlatformOrganizationsRequestDoc<TResult>(query: TypedDocumentNode<TResult, GraphQLVariables> | TypedDocumentNode<TResult, Exact<{
     [key: string]: never;
-}>>, token: string, organizationId: string, variables?: TVariables): Promise<TResult>;
\ No newline at end of file
+}>>, token: string, organizationId: string, variables?: GraphQLVariables): Promise<TResult>;
\ No newline at end of file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant