-
Notifications
You must be signed in to change notification settings - Fork 163
Add production-mode flag to app dev command #5694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
zzooeeyy
wants to merge
1
commit into
main
Choose a base branch
from
add-production-mode-flag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success2205 tests passing in 959 suites. Report generated by 🧪jest coverage report action from d1590d8 |
- Added `--production-mode` flag to `shopify app dev` command with default false - Updated `DevSessionOptions` and `DevSessionPayload` interfaces to include `productionMode` parameter - Added `productionMode` parameter to GraphQL dev session create/update mutations - Modified all related interfaces and classes to pass the flag through the API chain - Updated `DevSessionDelete` signature to omit both `assetsUrl` and `productionMode` Co-authored-by: Ryan DJ Lee <[email protected]>
7a0ae1c
to
dc440ad
Compare
fb1d50a
to
d1590d8
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/array.d.ts@@ -45,17 +45,4 @@ export declare function uniqBy<T>(array: List<T> | null | undefined, iteratee: V
* @param values - The arrays of values to exclude.
* @returns Returns the new array of filtered values.
*/
-export declare function difference<T>(array: List<T> | null | undefined, ...values: List<T>[]): T[];
-/**
- * Converts an array of anything into a human friendly list.
- *
- * Returns a new array that contains the items separated by commas,
- * except for the last item, which is separated by "and".
- * This is useful for creating human-friendly sentences.
- *
- * @param items - Token[].
- * @returns Token[].
- * @example
- *
- */
-export declare function asHumanFriendlyArray<T>(items: T[]): (T | string)[];
\ No newline at end of file
+export declare function difference<T>(array: List<T> | null | undefined, ...values: List<T>[]): T[];
\ No newline at end of file
packages/cli-kit/dist/public/node/api/business-platform.d.ts@@ -40,6 +40,6 @@ export declare function businessPlatformOrganizationsRequest<T>(query: string, t
* @param variables - GraphQL variables to pass to the query.
* @returns The response of the query of generic type <T>.
*/
-export declare function businessPlatformOrganizationsRequestDoc<TResult, TVariables extends Variables>(query: TypedDocumentNode<TResult, TVariables> | TypedDocumentNode<TResult, Exact<{
+export declare function businessPlatformOrganizationsRequestDoc<TResult>(query: TypedDocumentNode<TResult, GraphQLVariables> | TypedDocumentNode<TResult, Exact<{
[key: string]: never;
-}>>, token: string, organizationId: string, variables?: TVariables): Promise<TResult>;
\ No newline at end of file
+}>>, token: string, organizationId: string, variables?: GraphQLVariables): Promise<TResult>;
\ No newline at end of file
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist