EffOperations #7764
Open
EffOperations #7764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutionism
requested review from
APickledWalrus and
Efnilite
and removed request for
a team
sovdeeth
requested changes
Apr 4, 2025
src/main/java/org/skriptlang/skript/lang/arithmetic/Arithmetics.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,68 @@ | |||
| test "operations numbers": | |||
There was a problem hiding this comment.
needs tests where both values are variables, where the other value is not a valid option, where the value is a variable with an invalid type, etc. Edge cases need to be covered.
Efnilite
requested changes
Apr 4, 2025
UnderscoreTud
requested changes
Apr 5, 2025
src/main/java/org/skriptlang/skript/lang/arithmetic/Arithmetics.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Apr 6, 2025
sovdeeth
requested changes
Apr 6, 2025
src/main/java/org/skriptlang/skript/lang/arithmetic/Arithmetics.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Apr 11, 2025
Efnilite
requested changes
Apr 29, 2025
APickledWalrus
requested changes
Apr 30, 2025
| Operator operator, | ||
| Class<L> leftClass, | ||
| Class<R> rightClass, | ||
| Class<?> ... possibleReturnTypes |
There was a problem hiding this comment.
Suggested change
| Class<?> ... possibleReturnTypes | |
| Class<?>... possibleReturnTypes |
| OperationInfo<L, R, ?> info = lookupOperationInfo(operator, leftClass, rightClass); | ||
| if (info == null) | ||
| return null; | ||
| for (Class<?> returnType : possibleReturnTypes) { |
There was a problem hiding this comment.
You probably want to first check that the return type of the operation info is not one of possibleReturnTypes. That is, we want to avoid converting if possible.
Comment on lines
+110
to
+111
| if (leftType.isArray()) | ||
| leftType = leftType.getComponentType(); |
There was a problem hiding this comment.
i don't think this is necessary
| // for 'left's acceptedClasses | ||
| Class<?>[] allReturnTypes = Arithmetics.getAllReturnTypes(operator).toArray(Class[]::new); | ||
| if (!ChangerUtils.acceptsChangeTypes(leftAccepts, allReturnTypes)) { | ||
| Skript.error(left + " cannot be " + getOperatorName() + "."); |
There was a problem hiding this comment.
Suggested change
| Skript.error(left + " cannot be " + getOperatorName() + "."); | |
| Skript.error(left.toString(null, Skript.debug()) + " cannot be " + getOperatorName() + "."); |
It is not guaranteed that regular toString will return a readable result for an expression.
| return false; | ||
| } | ||
| return LiteralUtils.canInitSafely(right); | ||
| } else if (leftType.equals(Object.class) || rightType.equals(Object.class)) { |
There was a problem hiding this comment.
I would appreciate further docs for what is being done here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add effects for multiplication, division and exponentiation operations, allowing users to perform an arithmetic operation on an variable, single or list. Rather than doing, for example
set {_int} to {_int} * 2Does not work for literals.
Target Minecraft Versions: any
Requirements: none
Related Issues: #7763