Expand Custom Model Data syntaxes to support new CMD component #7807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
enhancement
sovdeeth
requested review from
Efnilite and
cheeezburga
and removed request for
a team
Efnilite
requested changes
Apr 22, 2025
src/main/java/ch/njol/skript/expressions/ExprCustomModelData.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/expressions/ExprCustomModelData.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/conditions/CondHasCustomModelData.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Efnilite <[email protected]>
Efnilite
requested changes
Apr 29, 2025
| @Since("2.5") | ||
| @Example("player's tool has custom model data") | ||
| @Since("2.5, INSERT VERSION (expanded data types)") | ||
| @RequiredPlugins("1.21.4+ (floats/flags/strings/colours)") |
There was a problem hiding this comment.
Suggested change
| @RequiredPlugins("1.21.4+ (floats/flags/strings/colours)") | |
| @RequiredPlugins("Minecraft 1.21.4+ (floats/flags/strings/colours)") |
| @Example(""" | ||
| set the full custom model data of {_item} to 10, "sword", and rgb(100, 200, 30) | ||
| """) | ||
| @RequiredPlugins("1.21.4+ (floats/flags/strings/colours/full model data)") |
There was a problem hiding this comment.
Suggested change
| @RequiredPlugins("1.21.4+ (floats/flags/strings/colours/full model data)") | |
| @RequiredPlugins("Minecraft 1.21.4+ (floats/flags/strings/colours/full model data)") |
| @Example("give player a diamond sword with custom model data 2") | ||
| @Example("set slot 1 of inventory of player to wooden hoe with custom model data 357") | ||
| @Example("give player a diamond hoe with custom model data 2, true, true, \"scythe\", and rgb(0,0,100)") | ||
| @RequiredPlugins("1.21.4+ (boolean/string/color support)") |
There was a problem hiding this comment.
Suggested change
| @RequiredPlugins("1.21.4+ (boolean/string/color support)") | |
| @RequiredPlugins("Minecraft 1.21.4+ (boolean/string/color support)") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All previous behavior should remain the same.
In 1.21.4+:
with model data %...%now supports numbers, strings, booleans, and colors.custom model data of {_x}. This remains the same as previous versions, a single int value. Setting this will remove any other CMD data on the item.custom model data (floats|flags|strings|colors) of {_x}. This returns a list of the given type from the custom model data and supports all changers.(full|complete) custom model data of {_x}. This returns a list of all the values in the CMD, in float-flag-string-color order. This supports all changers.Target Minecraft Versions: any
Requirements: none
Related Issues: #7782