Remove as much warnings as possible #63
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project goes rom 200+ warnings to 7 due to tools and third parties, 0 warning on project sources. - remove unused parameters warnings by commenting the parameter name - remove reorder warning by matching init order with declaration order - remove make "jobserver unavailable" warning by using $(MAKE) i.e. make in .pro file - fixed actual issues (e.g. missing return statement) - also uses XPCF MACROs for attributes so that we can disable them at once and remove GCC warnings on ignored atributes.
jim-bcom
force-pushed
the
feat/reduce-warnings
branch
3 times, most recently
from
6847a9e to
f0e5bae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project goes rom 200+ warnings to 7 due to tools and third parties, 0 warning on project sources.