Skip to content

Hotfix: 외부 포트폴리오에 대한 첨삭 오류 해결#389

Merged
hyoinkang merged 1 commit intomainfrom
hotfix-correction
May 1, 2026
Merged

Hotfix: 외부 포트폴리오에 대한 첨삭 오류 해결#389
hyoinkang merged 1 commit intomainfrom
hotfix-correction

Conversation

@hyoinkang
Copy link
Copy Markdown
Contributor

@hyoinkang hyoinkang commented May 1, 2026

Summary

  • fix: 첨삭 상세 조회에 대한 INTERNAL 필터 처리 제거

  • refactor: 불필요한 계층구조 제거

  • 서비스 로직이 줄어듦에 따라 파사드 대신 서비스를 직접 호출하도록 리팩토링함

Type of Change

해당하는 항목에 체크해주세요:

  • Bug fix (기존 기능을 수정하는 변경)
  • New feature (새로운 기능 추가)
  • Breaking change (기존 기능에 영향을 주는 변경)
  • Refactoring (기능 변경 없이 코드 개선)
  • Documentation (문서 변경)
  • Chore (빌드, 설정 등)

Target Environment

배포 대상 브랜치를 선택해주세요:

  • Dev (dev)
  • Prod (main)

* fix: 첨삭 상세 조회에 대한 INTERNAL 필터 처리 제거

* refactor: 불필요한 계층구조 제거

- 서비스 로직이 줄어듦에 따라 파사드 대신 서비스를 직접 호출하도록 리팩토링함
@hyoinkang hyoinkang self-assigned this May 1, 2026
@hyoinkang hyoinkang added 🐛 fix Something isn't working 효인 labels May 1, 2026
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

본 PR은 외부 포트폴리오 첨삭 조회 시 발생하는 오류를 해결하고, 코드의 복잡도를 낮추기 위해 불필요한 파사드 계층을 제거하는 리팩토링을 수행했습니다. 이를 통해 서비스 호출 구조를 단순화하고 유지보수성을 개선했습니다.

Highlights

  • 코드 리팩토링: 불필요한 계층 구조를 제거하고 파사드 패턴 대신 서비스 레이어를 직접 호출하도록 변경하여 서비스 로직을 간소화했습니다.
  • 기능 수정: 첨삭 상세 조회 시 적용되던 INTERNAL 필터 로직을 제거하여 외부 포트폴리오 첨삭 오류를 해결했습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hyoinkang hyoinkang merged commit b63e1c3 into main May 1, 2026
2 checks passed
@hyoinkang hyoinkang deleted the hotfix-correction branch May 1, 2026 00:10
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이번 풀 리퀘스트에서는 InternalCorrectionFacade를 삭제하고, InternalCorrectionController에서 PortfolioCorrectionService를 직접 호출하도록 변경되었습니다. 기존 Facade에 포함되어 있던 내부 포트폴리오 필터링 로직이 제거되었으며, 현재 검토할 리뷰 코멘트가 없으므로 별도의 피드백은 제공하지 않습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 fix Something isn't working 효인

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant