Skip to content

Hotfix: 외부 포트폴리오에 대한 첨삭 오류 해결 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyoinkang merged 1 commit into from
May 1, 2026
Merged

Hotfix: 외부 포트폴리오에 대한 첨삭 오류 해결 #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 0 additions & 45 deletions src/modules/internal/application/facades/internal-correction.facade.ts
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/modules/internal/internal.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ import { PortfolioCorrectionModule } from '../portfolio-correction/portfolio-cor
import { AiClientExceptionFilter } from 'src/common/filters/ai-client-exception.filter';
import { InternalCorrectionResultFacade } from './application/facades/internal-correction-result.facade';
import { InternalPdfExtractionResultController } from './presentation/internal-pdf-extraction-result.controller';
import { InternalCorrectionFacade } from './application/facades/internal-correction.facade';

@Module({
imports: [InsightModule, PortfolioModule, PortfolioCorrectionModule, ExperienceModule],
controllers: [
Expand All @@ -24,7 +22,6 @@ import { InternalCorrectionFacade } from './application/facades/internal-correct
providers: [
InternalApiKeyGuard,
InternalPortfolioFacade,
InternalCorrectionFacade,
AiClientExceptionFilter,
InternalCorrectionResultFacade,
],
Expand Down
8 changes: 2 additions & 6 deletions src/modules/internal/presentation/internal-correction.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { ApiCommonErrorResponse, ApiCommonResponse } from 'src/common/decorators
import { ErrorCode } from 'src/common/exceptions/error-code.enum';
import { PortfolioCorrectionService } from 'src/modules/portfolio-correction/application/services/portfolio-correction.service';
import { InternalApiKeyGuard } from 'src/common/guards/internal-api-key.guard';
import { InternalCorrectionFacade } from '../application/facades/internal-correction.facade';
import {
InternalCorrectionResDTO,
UpdateCompanyInsightInternalReqDTO,
Expand All @@ -15,10 +14,7 @@ import {
@ApiTags('Internal - Corrections')
@Controller('corrections')
export class InternalCorrectionController {
constructor(
private readonly portfolioCorrectionService: PortfolioCorrectionService,
private readonly internalCorrectionFacade: InternalCorrectionFacade
) {}
constructor(private readonly portfolioCorrectionService: PortfolioCorrectionService) {}

@Get(':correctionId')
@Public()
Expand All @@ -39,7 +35,7 @@ export class InternalCorrectionController {
@Param('correctionId', ParseIntPipe) correctionId: number
): Promise<InternalCorrectionResDTO> {
const payload =
await this.internalCorrectionFacade.getInternalCorrectionDetail(correctionId);
await this.portfolioCorrectionService.getInternalCorrectionDetail(correctionId);
return InternalCorrectionResDTO.from(payload);
}

Expand Down
Loading