This repository was archived by the owner on Mar 28, 2025. It is now read-only.
Merged
Conversation
tdilauro
approved these changes
Aug 31, 2021
Contributor
tdilauro
left a comment
tdilauro
left a comment
There was a problem hiding this comment.
This looks good to me, at least conceptually.
I don't have any experience with the variable/reference syntax I see in the tox.ini, but it looks really convenient.
Member
Author
|
@tdilauro @vbessonov I'm going to resolve the conflicts on this PR and merge it now that ThePalaceProject/circulation#39 has gone in. Any objections? |
- Add flake8, black and isort to our tox configuraion. - Make black and isort run automatically with tox and gh actions workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to ThePalaceProject/library-registry#23 this PR adds a linting step to our CI pipeline. The bulk of this PR is automatic reformatting done by isort and black. The CI changes are all in 603393f.