refactor(logic): Remove double initialization of camera zoom and angles #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Minor
Skyaero42
requested changes
Sep 18, 2025
| } | ||
|
|
||
| // Set up the camera height based on the map height & globalData. | ||
| TheTacticalView->initHeightForMap(); |
There was a problem hiding this comment.
initHeightForMap relies on m_pos to calculate the ground height. Since m_pos is only updated after lookAt is called, removing this second initHeightForMap means the height adjustment would be skipped for the initial camera position. That’s why this call seems necessary.
|
|
||
| // Set up the camera height based on the map height & globalData. | ||
| TheTacticalView->initHeightForMap(); | ||
| TheTacticalView->setAngleAndPitchToDefault(); |
There was a problem hiding this comment.
Both setAngleAndPitchToDefault() and setZoomToDefault() call setCameraTransform() which also relies on m_pos
|
I think height above ground update needs looking at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the double initialization of camera zoom and angles in
GameLogic::startNewGame. User facing nothing changes.TODO