refactor(pathfinder): Simplify functions to improve readability - Part 3 #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyaero42
requested changes
Sep 28, 2025
|
going to add one more function to this that i noticed, only some small changes to it |
Mauller
force-pushed
the
refactor-pathfinding-simplify-code-3
branch
from
b331e23 to
10189db
Compare
|
just a rebase |
|
Added extra commit |
Caball009
reviewed
Sep 30, 2025
Mauller
force-pushed
the
refactor-pathfinding-simplify-code-3
branch
from
26be73e to
4d6fd78
Compare
|
Updated based on feedback. |
Mauller
force-pushed
the
refactor-pathfinding-simplify-code-3
branch
2 times, most recently
from
1963ae8 to
84ce7dd
Compare
|
updated based on feedback |
|
This needs to be replicated in Generals. |
…:checkDestination (#1645)
…:snapClosestGoalPosition (#1645)
…:examineCellsCallback (#1645)
…:checkForMovement (#1645)
…:moveAllies (#1645)
Mauller
force-pushed
the
refactor-pathfinding-simplify-code-3
branch
from
84ce7dd to
fa7bc60
Compare
|
Copied across to generals with minor differences, some dips in performance seem to be reduced at points when i play back GR1 but nothing major. Like only hitting 19FPS min instead of 14FPS with all pathfinder refactors in place. |
xezon
changed the title
xezon
pushed a commit
that referenced
this pull request
Oct 11, 2025
…:snapClosestGoalPosition (#1645)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3 in this munkee series of magic.
This PR cleans up various functions within the pathfinding, the goal to improve readability where possible and to improve performance where possible.
I have broken each function down into it's own commit to aid review.
This PR covers the functions
A few of the refactors cover code simplification by inverting the logic and returning early or by simplifying functionality.
Todo