Feat(vscode): Add the Table Diff view in the extension #4917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfdking
reviewed
Jul 7, 2025
vscode/extension/src/lsp/custom.ts
Outdated
Comment on lines
43
to
47
| interface AllModelsResponse extends BaseResponse { | ||
| models: string[] | ||
| model_completions: ModelCompletion[] | ||
| keywords: string[] | ||
| macros: MacroCompletion[] | ||
| } | ||
|
|
||
| interface ModelCompletion { | ||
| name: string | ||
| description?: string | ||
| } | ||
|
|
||
| interface MacroCompletion { | ||
| name: string | ||
| description?: string | ||
| } |
There was a problem hiding this comment.
The reason for this not being updated, is that it is legacy and so it really should just be dropped.
There was a problem hiding this comment.
removed these and created a new get_models_feature to use
Comment on lines
+18
to
+19
| const panelType = (window as any).__SQLMESH_PANEL_TYPE__ || 'lineage' | ||
| return panelType === 'tablediff' ? <TableDiffPage /> : <LineagePage /> |
There was a problem hiding this comment.
I avoided this problem initially, but I am not sure this is quite the way we want to do it. To me it's about loading the specific page and we can break it up as much as possible for the performance.
There was a problem hiding this comment.
I agree, check if what I added makes more sense
vscode/react/src/pages/tablediff.tsx
Outdated
Comment on lines
67
to
166
| const [selectedModel, setSelectedModel] = useState<string | undefined>( | ||
| undefined, | ||
| ) | ||
| const { on } = useEventBus() | ||
| const queryClient = useQueryClient() | ||
|
|
||
| const { | ||
| data: models, | ||
| isLoading: isLoadingModels, | ||
| error: modelsError, | ||
| } = useApiModels() | ||
| const rpc = useRpc() | ||
|
|
||
| React.useEffect(() => { | ||
| const fetchFirstTimeModelIfNotSet = async ( | ||
| models: Model[], | ||
| ): Promise<string | undefined> => { | ||
| if (!Array.isArray(models)) { | ||
| return undefined | ||
| } | ||
| const activeFile = await rpc('get_active_file', {}) | ||
| // @ts-ignore | ||
| if (!activeFile.fileUri) { | ||
| return models[0].name | ||
| } | ||
| // @ts-ignore | ||
| const fileUri: string = activeFile.fileUri | ||
| const filePath = URI.file(fileUri).path | ||
| const model = models.find( | ||
| (m: Model) => URI.file(m.full_path).path === filePath, | ||
| ) | ||
| if (model) { | ||
| return model.name | ||
| } | ||
| return undefined | ||
| } | ||
| if (selectedModel === undefined && Array.isArray(models)) { | ||
| fetchFirstTimeModelIfNotSet(models).then(modelName => { | ||
| if (modelName && selectedModel === undefined) { | ||
| setSelectedModel(modelName) | ||
| } else { | ||
| setSelectedModel(models[0].name) | ||
| } | ||
| }) | ||
| } | ||
| }, [models, selectedModel]) | ||
|
|
||
| const modelsRecord = | ||
| Array.isArray(models) && | ||
| models.reduce( | ||
| (acc, model) => { | ||
| acc[model.name] = model | ||
| return acc | ||
| }, | ||
| {} as Record<string, Model>, | ||
| ) | ||
|
|
||
| React.useEffect(() => { | ||
| const handleChangeFocusedFile = (fileUri: { fileUri: string }) => { | ||
| const full_path = URI.parse(fileUri.fileUri).path | ||
| const model = Object.values(modelsRecord).find( | ||
| m => URI.file(m.full_path).path === full_path, | ||
| ) | ||
| if (model) { | ||
| setSelectedModel(model.name) | ||
| } | ||
| } | ||
|
|
||
| const handleSavedFile = () => { | ||
| queryClient.invalidateQueries() | ||
| } | ||
|
|
||
| const offChangeFocusedFile = on( | ||
| 'changeFocusedFile', | ||
| handleChangeFocusedFile, | ||
| ) | ||
| const offSavedFile = on('savedFile', handleSavedFile) | ||
|
|
||
| // If your event bus returns an "off" function, call it on cleanup | ||
| return () => { | ||
| if (offChangeFocusedFile) offChangeFocusedFile() | ||
| if (offSavedFile) offSavedFile() | ||
| } | ||
| }, [on, queryClient, modelsRecord]) | ||
|
|
||
| if (modelsError) { | ||
| return <div>Error: {modelsError.message}</div> | ||
| } | ||
|
|
||
| if ( | ||
| isLoadingModels || | ||
| models === undefined || | ||
| modelsRecord === false || | ||
| selectedModel === undefined | ||
| ) { | ||
| return <div>Loading models...</div> | ||
| } | ||
| if (!Array.isArray(models)) { | ||
| return <div>Error: Models data is not in the expected format</div> | ||
| } |
There was a problem hiding this comment.
Why do you need any of this?
There was a problem hiding this comment.
excellent point removed all of it
vscode/react/src/pages/tablediff.tsx
Outdated
| } | ||
|
|
||
| return ( | ||
| <div className="h-[100vh] w-[100vw]"> |
There was a problem hiding this comment.
Let's put this initial styling in the component.
| } | ||
| result: { | ||
| ok: boolean | ||
| data?: any |
There was a problem hiding this comment.
yep revised all these anys
sqlmesh/lsp/main.py
Outdated
Comment on lines
190
to
214
| for env in context.context.state_reader.get_environments(): | ||
| environments[env.name] = EnvironmentInfo( | ||
| name=env.name, | ||
| snapshots=[s.fingerprint.to_identifier() for s in env.snapshots], | ||
| start_at=str(to_timestamp(env.start_at)), | ||
| plan_id=env.plan_id or "", | ||
| ) | ||
|
|
||
| # Add prod if not present (mirroring web/server/api/endpoints/environments.py) | ||
| if c.PROD not in environments: | ||
| environments[c.PROD] = EnvironmentInfo( | ||
| name=c.PROD, | ||
| snapshots=[], | ||
| start_at=str(to_timestamp(c.EPOCH)), | ||
| plan_id="", | ||
| ) | ||
|
|
||
| # Add default target environment if not present | ||
| if context.context.config.default_target_environment not in environments: | ||
| environments[context.context.config.default_target_environment] = EnvironmentInfo( | ||
| name=context.context.config.default_target_environment, | ||
| snapshots=[], | ||
| start_at=str(to_timestamp(c.EPOCH)), | ||
| plan_id="", | ||
| ) |
There was a problem hiding this comment.
These are pretty big assumptions that aren't really listed in the "endpoint" definition.
There was a problem hiding this comment.
yeah mirroring the web version wasn't wise or needed, removed these
| // No active editor, show a list of all models | ||
| const allModelsResult = await lspClient.call_custom_method( | ||
| 'sqlmesh/all_models', | ||
| { textDocument: { uri: '' } }, |
There was a problem hiding this comment.
I am not certain we want to be using the all_models endpoint which was a legacy endpoint used for autocomplete.
|
|
||
| // Get the current active editor | ||
| const activeEditor = vscode.window.activeTextEditor | ||
| let selectedModelInfo: any = null |
| target: string | ||
| stats: Record<string, number> | ||
| sample: Record<string, any> | ||
| joined_sample: Record<string, any> |
There was a problem hiding this comment.
We shouldn't really haven anys
themisvaltinos
force-pushed
the
themis/vscode_tablediff
branch
from
2267d46 to
8d93e96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for table diff in the VSCode extension