Add error/exception case test coverage for ContractDomainService

[Copilot]

Each ContractDomainService method lacked tests for failure paths — aggregate fetch failures, state change failures, save failures, and transient query failures were all uncovered.

New test cases

CreateContract

• GetEstateFailed_ResultIsFailed — Get<EstateAggregate> returns failure
• GetContractFailed_ResultIsFailed — GetLatest<ContractAggregate> returns failure
• RunTransientQueryFailed_ResultIsFailed — RunTransientQuery returns failure
• SaveFailed_ResultIsFailed — Save returns failure

AddProductToContract (FixedValue + VariableValue variants)

• GetContractFailed_ResultIsFailed
• SaveFailed_ResultIsFailed

AddTransactionFeeForProductToContract (4 calc/fee type combos each)

• GetContractFailed_ResultIsFailed
• SaveFailed_ResultIsFailed

DisableTransactionFeeForProduct

• GetContractFailed_ResultIsFailed
• StateChangeFailed_ResultIsFailed — fee/product not found on aggregate
• SaveFailed_ResultIsFailed

All tests follow the existing pattern: mock the failing dependency, invoke the service method, assert result.IsFailed.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• f.feedz.io
  • Triggering command: /usr/bin/dotnet dotnet test TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --filter ContractDomainServiceTests -v minimal (dns block)
  • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.0/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.24.0/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp (dns block)
  • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.sln --packages /home/REDACTED/work/TransactionProcessor/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/TransactionProcessor/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/TransactionProcessor/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Update Test Coverage on Contract Domain service</issue_title>
<issue_description>Each domain service method needs new tests added to cover all cases, mainly error and exception cases missing</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Update Test Coverage on Contract Domain service #916

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.