Skip to content

Add error/exception case test coverage for ContractDomainService #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 4 commits into from
Feb 21, 2026
Merged

Add error/exception case test coverage for ContractDomainService #1514

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc36979
Initial plan
Copilot Feb 21, 2026
68f7369
Add missing test coverage for ContractDomainService error and excepti…
Copilot Feb 21, 2026
17fc484
final tweaks
StuartFerguson Feb 21, 2026
f35d942
Merge branch 'master' into copilot/update-test-coverage-contract-domain
StuartFerguson Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
258 changes: 258 additions & 0 deletions TransactionProcessor.BusinessLogic.Tests/Services/ContractDomainServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
using TransactionProcessor.Aggregates;
using TransactionProcessor.BusinessLogic.Requests;
using TransactionProcessor.BusinessLogic.Services;
using TransactionProcessor.DataTransferObjects.Requests.Contract;
using TransactionProcessor.Models.Contract;
using TransactionProcessor.Testing;
using Xunit;
Expand Down Expand Up @@ -289,5 +290,262 @@ public async Task ContractDomainService_DisableTransactionFeeForProduct_Transact
Result result = await this.DomainService.DisableTransactionFeeForProduct(command, CancellationToken.None);
result.IsSuccess.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_DisableTransactionFeeForProduct_GetContractFailed_ResultIsFailed()
{
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.DisableTransactionFeeForProductCommand command = TestData.Commands.DisableTransactionFeeForProductCommand;
Result result = await this.DomainService.DisableTransactionFeeForProduct(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_DisableTransactionFeeForProduct_StateChangeFailed_ResultIsFailed()
{
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Success(TestData.Aggregates.CreatedContractAggregate()));

ContractCommands.DisableTransactionFeeForProductCommand command = TestData.Commands.DisableTransactionFeeForProductCommand;
Result result = await this.DomainService.DisableTransactionFeeForProduct(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_DisableTransactionFeeForProduct_SaveFailed_ResultIsFailed()
{
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(TestData.Aggregates.CreatedContractAggregateWithAProductAndTransactionFee(CalculationType.Fixed, FeeType.Merchant));
this.AggregateService.Setup(c => c.Save(It.IsAny<ContractAggregate>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.DisableTransactionFeeForProductCommand command = TestData.Commands.DisableTransactionFeeForProductCommand;
Result result = await this.DomainService.DisableTransactionFeeForProduct(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_DisableTransactionFeeForProduct_ExceptionThrown_ResultIsFailed()
{
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(TestData.Aggregates.CreatedContractAggregateWithAProductAndTransactionFee(CalculationType.Fixed, FeeType.Merchant));
this.AggregateService.Setup(c => c.Save(It.IsAny<ContractAggregate>(), It.IsAny<CancellationToken>())).ThrowsAsync(new Exception());

ContractCommands.DisableTransactionFeeForProductCommand command = TestData.Commands.DisableTransactionFeeForProductCommand;
Result result = await this.DomainService.DisableTransactionFeeForProduct(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_CreateContract_GetEstateFailed_ResultIsFailed()
{
this.AggregateService.Setup(e => e.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.CreateContractCommand command = TestData.Commands.CreateContractCommand;
Result result = await this.DomainService.CreateContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_CreateContract_GetContractFailed_ResultIsFailed()
{
this.AggregateService.Setup(e => e.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(TestData.Aggregates.EstateAggregateWithOperator());
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.CreateContractCommand command = TestData.Commands.CreateContractCommand;
Result result = await this.DomainService.CreateContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_CreateContract_RunTransientQueryFailed_ResultIsFailed()
{
this.AggregateService.Setup(e => e.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(TestData.Aggregates.EstateAggregateWithOperator());
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Success(TestData.Aggregates.EmptyContractAggregate()));
this.EventStoreContext.Setup(c => c.RunTransientQuery(It.IsAny<String>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.CreateContractCommand command = TestData.Commands.CreateContractCommand;
Result result = await this.DomainService.CreateContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_CreateContract_StateChangeFailed_ResultIsFailed()
{
this.AggregateService.Setup(e => e.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(TestData.Aggregates.EstateAggregateWithOperator());
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Success(TestData.Aggregates.EmptyContractAggregate()));
this.EventStoreContext.Setup(c => c.RunTransientQuery(It.IsAny<String>(), It.IsAny<CancellationToken>()))
.ReturnsAsync("{\r\n \"total\": 0,\r\n \"contractId\": \"\"\r\n}");
//this.AggregateService.Setup(c => c.Save(It.IsAny<ContractAggregate>(), It.IsAny<CancellationToken>()))
// .ReturnsAsync(Result.Failure());

ContractCommands.CreateContractCommand command = TestData.Commands.CreateContractCommand;
command = command with {
RequestDTO = new CreateContractRequest {
Description = String.Empty,
OperatorId = TestData.Commands.CreateContractCommand.RequestDTO.OperatorId
}
};
Result result = await this.DomainService.CreateContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_CreateContract_SaveFailed_ResultIsFailed()
{
this.AggregateService.Setup(e => e.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(TestData.Aggregates.EstateAggregateWithOperator());
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Success(TestData.Aggregates.EmptyContractAggregate()));
this.EventStoreContext.Setup(c => c.RunTransientQuery(It.IsAny<String>(), It.IsAny<CancellationToken>()))
.ReturnsAsync("{\r\n \"total\": 0,\r\n \"contractId\": \"\"\r\n}");
this.AggregateService.Setup(c => c.Save(It.IsAny<ContractAggregate>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.CreateContractCommand command = TestData.Commands.CreateContractCommand;
Result result = await this.DomainService.CreateContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_CreateContract_ExceptionThrown_ResultIsFailed()
{
this.AggregateService.Setup(e => e.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(TestData.Aggregates.EstateAggregateWithOperator());
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Success(TestData.Aggregates.EmptyContractAggregate()));
this.EventStoreContext.Setup(c => c.RunTransientQuery(It.IsAny<String>(), It.IsAny<CancellationToken>()))
.ReturnsAsync("{\r\n \"total\": 0,\r\n \"contractId\": \"\"\r\n}");
this.AggregateService.Setup(c => c.Save(It.IsAny<ContractAggregate>(), It.IsAny<CancellationToken>())).ThrowsAsync(new Exception());

ContractCommands.CreateContractCommand command = TestData.Commands.CreateContractCommand;
Result result = await this.DomainService.CreateContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_AddProductToContract_FixedValue_GetContractFailed_ResultIsFailed()
{
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.AddProductToContractCommand command = TestData.Commands.AddProductToContractCommand_FixedValue;
Result result = await this.DomainService.AddProductToContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_AddProductToContract_VariableValue_GetContractFailed_ResultIsFailed()
{
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.AddProductToContractCommand command = TestData.Commands.AddProductToContractCommand_VariableValue;
Result result = await this.DomainService.AddProductToContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_AddProductToContract_FixedValue_StateChangeFailed_ResultIsFailed()
{
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Success(TestData.Aggregates.CreatedContractAggregate()));
this.AggregateService.Setup(c => c.Save(It.IsAny<ContractAggregate>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.AddProductToContractCommand command = TestData.Commands.AddProductToContractCommand_FixedValue;
command = command with { ProductId = Guid.Empty };
Result result = await this.DomainService.AddProductToContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_AddProductToContract_FixedValue_SaveFailed_ResultIsFailed()
{
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Success(TestData.Aggregates.CreatedContractAggregate()));
this.AggregateService.Setup(c => c.Save(It.IsAny<ContractAggregate>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.AddProductToContractCommand command = TestData.Commands.AddProductToContractCommand_FixedValue;
Result result = await this.DomainService.AddProductToContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_AddProductToContract_VariableValue_SaveFailed_ResultIsFailed()
{
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Success(TestData.Aggregates.CreatedContractAggregate()));
this.AggregateService.Setup(c => c.Save(It.IsAny<ContractAggregate>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.AddProductToContractCommand command = TestData.Commands.AddProductToContractCommand_VariableValue;
Result result = await this.DomainService.AddProductToContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Theory]
[InlineData(DataTransferObjects.Responses.Contract.CalculationType.Fixed, DataTransferObjects.Responses.Contract.FeeType.Merchant)]
[InlineData(DataTransferObjects.Responses.Contract.CalculationType.Percentage, DataTransferObjects.Responses.Contract.FeeType.Merchant)]
[InlineData(DataTransferObjects.Responses.Contract.CalculationType.Fixed, DataTransferObjects.Responses.Contract.FeeType.ServiceProvider)]
[InlineData(DataTransferObjects.Responses.Contract.CalculationType.Percentage, DataTransferObjects.Responses.Contract.FeeType.ServiceProvider)]
public async Task ContractDomainService_AddTransactionFeeForProductToContract_GetContractFailed_ResultIsFailed(
DataTransferObjects.Responses.Contract.CalculationType calculationType,
DataTransferObjects.Responses.Contract.FeeType feeType)
{
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.AddTransactionFeeForProductToContractCommand command =
TestData.Commands.AddTransactionFeeForProductToContractCommand(calculationType, feeType);
Result result = await this.DomainService.AddTransactionFeeForProductToContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Theory]
[InlineData(DataTransferObjects.Responses.Contract.CalculationType.Fixed, DataTransferObjects.Responses.Contract.FeeType.Merchant)]
[InlineData(DataTransferObjects.Responses.Contract.CalculationType.Percentage, DataTransferObjects.Responses.Contract.FeeType.Merchant)]
[InlineData(DataTransferObjects.Responses.Contract.CalculationType.Fixed, DataTransferObjects.Responses.Contract.FeeType.ServiceProvider)]
[InlineData(DataTransferObjects.Responses.Contract.CalculationType.Percentage, DataTransferObjects.Responses.Contract.FeeType.ServiceProvider)]
public async Task ContractDomainService_AddTransactionFeeForProductToContract_SaveFailed_ResultIsFailed(
DataTransferObjects.Responses.Contract.CalculationType calculationType,
DataTransferObjects.Responses.Contract.FeeType feeType)
{
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Success(TestData.Aggregates.CreatedContractAggregateWithAProduct()));
this.AggregateService.Setup(c => c.Save(It.IsAny<ContractAggregate>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.AddTransactionFeeForProductToContractCommand command =
TestData.Commands.AddTransactionFeeForProductToContractCommand(calculationType, feeType);
Result result = await this.DomainService.AddTransactionFeeForProductToContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task ContractDomainService_AddTransactionFeeForProductToContract_StateChangeFailed_ResultIsFailed()
{
this.AggregateService.Setup(c => c.GetLatest<ContractAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Success(TestData.Aggregates.CreatedContractAggregateWithAProduct()));
this.AggregateService.Setup(c => c.Save(It.IsAny<ContractAggregate>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Failure());

ContractCommands.AddTransactionFeeForProductToContractCommand command =
TestData.Commands.AddTransactionFeeForProductToContractCommand(DataTransferObjects.Responses.Contract.CalculationType.Fixed, DataTransferObjects.Responses.Contract.FeeType.Merchant);
command = command with { TransactionFeeId = Guid.Empty };
Result result = await this.DomainService.AddTransactionFeeForProductToContract(command, CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}
}
}
Loading