Skip to content

Add missing test coverage for VoucherDomainService failure paths #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 4 commits into from
Feb 23, 2026
Merged

Add missing test coverage for VoucherDomainService failure paths #1543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48a8ce3
Initial plan
Copilot Feb 23, 2026
b9595a2
Initial plan for VoucherDomainService test coverage
Copilot Feb 23, 2026
234f867
Add missing test cases to VoucherDomainServiceTests for improved cove…
Copilot Feb 23, 2026
27b96a1
Merge branch 'master' into copilot/update-test-coverage-voucher-service
StuartFerguson Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NuGet.Config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
</packageSources>
<packageSourceCredentials>
<Feedz>
<add key="Username" value="TestUser"/>
<add key="Username" value="TestUser" />
<add key="ClearTextPassword" value="T-jXeJSPLLjOdZvRZOQ5O2e1vrQwRI7uxC1U" />
</Feedz>
</packageSourceCredentials>
Expand Down
63 changes: 63 additions & 0 deletions TransactionProcessor.BusinessLogic.Tests/Services/VoucherDomainServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,69 @@ public async Task VoucherDomainService_RedeemVoucher_VoucherNotFound_ErrorThrown
CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task VoucherDomainService_IssueVoucher_GetVoucherFailed_ErrorThrown() {
this.AggregateService.Setup(v => v.GetLatest<VoucherAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Failure());
this.AggregateService.Setup(f => f.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.Aggregates.EstateAggregateWithOperator()));

Result<IssueVoucherResponse> result = await this.VoucherDomainService.IssueVoucher(TestData.IssueVoucherCommand,
CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task VoucherDomainService_IssueVoucher_SaveFailed_ErrorThrown() {
this.AggregateService.Setup(v => v.GetLatest<VoucherAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(new VoucherAggregate()));
this.AggregateService.Setup(v => v.Save(It.IsAny<VoucherAggregate>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Failure);
this.AggregateService.Setup(f => f.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.Aggregates.EstateAggregateWithOperator()));

Result<IssueVoucherResponse> result = await this.VoucherDomainService.IssueVoucher(TestData.IssueVoucherCommand,
CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task VoucherDomainService_RedeemVoucher_GetVoucherAggregateFailed_ErrorThrown() {
this.AggregateService.Setup(v => v.GetLatest<VoucherAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Failure());
this.AggregateService.Setup(f => f.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.Aggregates.CreatedEstateAggregate()));

this.Context.VoucherProjectionStates.Add(new TransactionProcessor.Database.Entities.VoucherProjectionState() {
VoucherCode = TestData.VoucherCode,
OperatorIdentifier = TestData.OperatorIdentifier,
Barcode = TestData.Barcode,
Timestamp = BitConverter.GetBytes(DateTime.UtcNow.Ticks)
});
await this.Context.SaveChangesAsync();

Result<RedeemVoucherResponse> result = await this.VoucherDomainService.RedeemVoucher(TestData.EstateId,
TestData.VoucherCode,
TestData.RedeemedDateTime,
CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task VoucherDomainService_RedeemVoucher_SaveFailed_ErrorThrown() {
this.AggregateService.Setup(v => v.GetLatest<VoucherAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>()))
.ReturnsAsync(Result.Success(TestData.GetVoucherAggregateWithRecipientMobile()));
this.AggregateService.Setup(v => v.Save(It.IsAny<VoucherAggregate>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Failure);
this.AggregateService.Setup(f => f.Get<EstateAggregate>(It.IsAny<Guid>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Success(TestData.Aggregates.CreatedEstateAggregate()));

this.Context.VoucherProjectionStates.Add(new TransactionProcessor.Database.Entities.VoucherProjectionState() {
VoucherCode = TestData.VoucherCode,
OperatorIdentifier = TestData.OperatorIdentifier,
Barcode = TestData.Barcode,
Timestamp = BitConverter.GetBytes(DateTime.UtcNow.Ticks)
});
await this.Context.SaveChangesAsync();

Result<RedeemVoucherResponse> result = await this.VoucherDomainService.RedeemVoucher(TestData.EstateId,
TestData.VoucherCode,
TestData.RedeemedDateTime,
CancellationToken.None);
result.IsFailed.ShouldBeTrue();
}

private EstateManagementContext GetContext(String databaseName)
{
Expand Down
Loading