Add missing test coverage for VoucherDomainService failure paths#1543
Merged
StuartFerguson merged 4 commits intomasterfrom Feb 23, 2026
Merged
Add missing test coverage for VoucherDomainService failure paths#1543StuartFerguson merged 4 commits intomasterfrom
StuartFerguson merged 4 commits intomasterfrom
Conversation
Co-authored-by: StuartFerguson <[email protected]>
…rage Co-authored-by: StuartFerguson <[email protected]>
Copilot
AI
changed the title
[WIP] Update test coverage on voucher domain service
Add missing test coverage for VoucherDomainService failure paths
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VoucherDomainServicelacked test coverage for aggregate fetch failures and save failures in bothIssueVoucherandRedeemVoucher.New Tests
IssueVoucherVoucherDomainService_IssueVoucher_GetVoucherFailed_ErrorThrown—GetLatest<VoucherAggregate>returnsResult.Failure()after estate validation passesVoucherDomainService_IssueVoucher_SaveFailed_ErrorThrown—SavereturnsResult.Failureafter successful generate/barcode/issue stepsRedeemVoucherVoucherDomainService_RedeemVoucher_GetVoucherAggregateFailed_ErrorThrown—GetLatest<VoucherAggregate>returnsResult.Failure()after voucher projection is found in DB and estate validation passesVoucherDomainService_RedeemVoucher_SaveFailed_ErrorThrown—SavereturnsResult.Failureafter successful redeem stepEach test asserts
result.IsFailed.ShouldBeTrue(), consistent with the pattern used across other domain service test files (FloatDomainServiceTests,EstateDomainServiceTests).Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
f.feedz.io/usr/bin/dotnet dotnet test TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --filter FullyQualifiedName~VoucherDomainService --no-build(dns block)/usr/bin/dotnet dotnet build TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj(dns block)/usr/bin/dotnet dotnet restore TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --ignore-failed-sources(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.