Refactor MerchantStatementForDateAggregate.GetStatement to reduce method size#1683
Merged
StuartFerguson merged 2 commits intomasterfrom Mar 18, 2026
Merged
Conversation
Co-authored-by: StuartFerguson <[email protected]>
Copilot
AI
changed the title
[WIP] [Complexity] Reduce lines of code in GetStatement method
Refactor Mar 18, 2026
MerchantStatementForDateAggregate.GetStatement to reduce method size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codacy flagged
MerchantStatementForDateAggregateExtensions.GetStatementfor exceeding the repository’s line-count threshold. This change reduces the method size without changing statement construction or line-population behavior.Refactor
GetStatementCreateStatement(...)helper.PopulateStatementLines(...)helper.Behavior preserved
MerchantStatementForDate.includeStatementLinesistrue.Result
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
f.feedz.io/usr/bin/dotnet dotnet test /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.Aggregates.Tests/TransactionProcessor.Aggregates.Tests.csproj --filter MerchantStatementForDateAggregateTests --no-restore -nologo(dns block)/usr/bin/dotnet dotnet test /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.Tests/TransactionProcessor.Tests.csproj --filter VerifyBootstrapperIsValid --no-restore -nologo(dns block)/usr/bin/dotnet dotnet build /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.Aggregates/TransactionProcessor.Aggregates.csproj -p:RestoreIgnoreFailedSources=true -nologo(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.