Skip to content

Refactor MerchantStatementForDateAggregate.GetStatement to reduce method size #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 2 commits into from
Mar 18, 2026
Merged

Refactor MerchantStatementForDateAggregate.GetStatement to reduce method size #1683

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8744f58
Initial plan
Copilot Mar 18, 2026
66a3749
refactor: split merchant statement creation helpers
Copilot Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions TransactionProcessor.Aggregates/MerchantStatementForDateAggregate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,28 +168,35 @@ public static void PlayEvent(this MerchantStatementForDateAggregate aggregate, M

public static MerchantStatementForDate GetStatement(this MerchantStatementForDateAggregate aggregate, Boolean includeStatementLines = false)
{
MerchantStatementForDate merchantStatement = new MerchantStatementForDate
{
EstateId = aggregate.EstateId,
MerchantId = aggregate.MerchantId,
MerchantStatementId = aggregate.MerchantStatementId,
IsCreated = aggregate.IsCreated,
ActivityDate = aggregate.ActivityDate,
MerchantStatementForDateId = aggregate.AggregateId,
StatementDate = aggregate.StatementDate
};
MerchantStatementForDate merchantStatement = aggregate.CreateStatement();

if (includeStatementLines)
{
merchantStatement.AddStatementLines(aggregate.Transactions, transaction => transaction.Amount, transaction => transaction.DateTime, TransactionLineType);
merchantStatement.AddStatementLines(aggregate.SettledFees, settledFee => settledFee.Amount, settledFee => settledFee.DateTime, SettledFeeLineType);
merchantStatement.AddStatementLines(aggregate.Deposits, deposit => deposit.Amount, deposit => deposit.DepositDateTime, DepositLineType);
merchantStatement.AddStatementLines(aggregate.Withdrawals, withdrawal => withdrawal.Amount, withdrawal => withdrawal.WithdrawalDateTime, WithdrawalLineType);
merchantStatement.PopulateStatementLines(aggregate);
}

return merchantStatement;
}

private static MerchantStatementForDate CreateStatement(this MerchantStatementForDateAggregate aggregate) => new()
{
EstateId = aggregate.EstateId,
MerchantId = aggregate.MerchantId,
MerchantStatementId = aggregate.MerchantStatementId,
IsCreated = aggregate.IsCreated,
ActivityDate = aggregate.ActivityDate,
MerchantStatementForDateId = aggregate.AggregateId,
StatementDate = aggregate.StatementDate
};

private static void PopulateStatementLines(this MerchantStatementForDate merchantStatement, MerchantStatementForDateAggregate aggregate)
{
merchantStatement.AddStatementLines(aggregate.Transactions, transaction => transaction.Amount, transaction => transaction.DateTime, TransactionLineType);
merchantStatement.AddStatementLines(aggregate.SettledFees, settledFee => settledFee.Amount, settledFee => settledFee.DateTime, SettledFeeLineType);
merchantStatement.AddStatementLines(aggregate.Deposits, deposit => deposit.Amount, deposit => deposit.DepositDateTime, DepositLineType);
merchantStatement.AddStatementLines(aggregate.Withdrawals, withdrawal => withdrawal.Amount, withdrawal => withdrawal.WithdrawalDateTime, WithdrawalLineType);
}

private static void AddStatementLines<T>(this MerchantStatementForDate merchantStatement,
IEnumerable<T> source,
Func<T, Decimal> amountSelector,
Expand Down
Loading