Merged
Conversation
Expands AttributeUsage on TraxAuthorizeAttribute from Class to Class | Interface so IServiceTrain<TIn, TOut> contract interfaces can carry authorization metadata directly. Downstream readers (TrainDiscoveryService, AuthorizationRegistrationValidator) already walk inheritance via GetCustomAttributes(inherit: true), so interface-side declarations flow through to the implementation's registration entry without further changes. Also documents the combinator semantics when multiple attributes are applied: policies are AND'd across attributes, roles are unioned and OR'd, within a single attribute Roles is a comma-separated OR list.
|
This PR is included in version 1.32.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AttributeUsageonTraxAuthorizeAttributefromClasstoClass | InterfacesoIServiceTrain<TIn, TOut>contract interfaces can carry authorization metadata directly.Why this lands first
This is a prerequisite for the Trax.Mediator PR in the same feature series. Mediator's
AuthorizationRegistrationValidatorandTrainDiscoveryAuthorizationTestsplace[TraxAuthorize]on interface-side train contracts; those tests fail to compile against the currently-published Trax.Effect.Paired PRs
Test plan
dotnet buildzero warnings