Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eta facet names inaccurate grouping (#144) #151

Closed
wants to merge 3 commits into from

Conversation

billdenney
Copy link
Contributor

This replaces PR #145 and fixes #144 (updated to the new master and removed a pesky commit that was inaccurately in the last version)

@billdenney billdenney mentioned this pull request Mar 25, 2019
@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f2bbab5). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #151   +/-   ##
========================================
  Coverage          ?   94.4%           
========================================
  Files             ?      40           
  Lines             ?    3055           
  Branches          ?       0           
========================================
  Hits              ?    2884           
  Misses            ?     171           
  Partials          ?       0
Impacted Files Coverage Δ
R/plot_distribution.R 93.47% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2bbab5...70b22bd. Read the comment docs.

@billdenney billdenney changed the base branch from master to dev November 2, 2019 01:20
@billdenney
Copy link
Contributor Author

@guiastrennec, I've rebased this to dev for easier pulling.

@bguiastr bguiastr closed this Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants