Skip to content

fix(frontend): make local view fit fill toggle effective #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaolefang-dm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(frontend): make local view fit fill toggle effective #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions app/frontend/lib/pages/operate_tab.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,15 +506,27 @@ class _LocalPlanningViewState extends ConsumerState<_LocalPlanningView> {
ClipRect(
child: LayoutBuilder(
builder: (context, constraints) {
final side = widget.fillViewport
? max(constraints.maxWidth, constraints.maxHeight)
: min(constraints.maxWidth, constraints.maxHeight);
final gi = p?.gridInfo;
final contentAspect =
(gi != null && gi.height > 0) ? gi.width / gi.height : 1.0;
final viewportAspect = constraints.maxWidth / constraints.maxHeight;
final useWidth = widget.fillViewport
? viewportAspect > contentAspect
: viewportAspect < contentAspect;
final contentWidth = useWidth
? constraints.maxWidth
: constraints.maxHeight * contentAspect;
final contentHeight = useWidth
? constraints.maxWidth / contentAspect
: constraints.maxHeight;
final contentSize = Size(contentWidth, contentHeight);
final targetPose = _pendingTarget != null
? TrajPoint(_pendingTarget!.x, _pendingTarget!.y)
: p?.navTargetPose;
return Center(
child: SizedBox.square(
dimension: side,
child: SizedBox(
width: contentWidth,
height: contentHeight,
child: Builder(
builder: (mapContext) {
final content = widget.show3d
Expand Down Expand Up @@ -568,7 +580,7 @@ class _LocalPlanningViewState extends ConsumerState<_LocalPlanningView> {
);
return Listener(
behavior: HitTestBehavior.translucent,
onPointerDown: (event) => _startManualTargetTimer(event, Size(side, side)),
onPointerDown: (event) => _startManualTargetTimer(event, contentSize),
onPointerMove: _maybeCancelManualTargetTimer,
onPointerUp: (_) => _cancelManualTargetTimer(),
onPointerCancel: (_) => _cancelManualTargetTimer(),
Expand Down
Loading