Some PoC.arith tests converted to OSVVM #25
Conversation
|
@gmartina any ideas why your PR didn't launch a workflow run in GitHub Actions? |
There was a problem hiding this comment.
Please check my findings and try to push a new commit, so GitHub Actions gets triggered. Usually GitHub should propose a button to allow your CI run.
All other code and style is very good.
/cc @stefanunrein
tb/arith/addw/arith_addw_Simple.vhdl
Outdated
| -- vim: tabstop=2:shiftwidth=2:noexpandtab | ||
| -- kate: tab-width 2; replace-tabs off; indent-width 2; | ||
| -- ============================================================================= | ||
| -- Authors: |
There was a problem hiding this comment.
Please add your author name and the original name from the old file(s).
tb/arith/addw/arith_addw_Simple.vhdl
Outdated
| use entity work.arith_addw_TestController(Simple); | ||
| end for; | ||
| end for; | ||
| end configuration; No newline at end of file |
There was a problem hiding this comment.
Missing linebreak at the end of the file.
There was a problem hiding this comment.
Some other files have also missing linebreaks at the end.
| WaitForClock(Clock); | ||
| WaitForClock(Clock); |
There was a problem hiding this comment.
| WaitForClock(Clock); | |
| WaitForClock(Clock); | |
| WaitForClock(Clock, 2); |
WaitForClock has a second optional parameter for the number of clock cycles. default = 1
@Paebbels the workflow is blocked. This is what I see in Actions:
PR updated. |
|
This time I see a button and I activated it. I think once your PR is successful and merged, further PRs should be active right a way. Otherwise I can also upgrade your account as a contributor - if you like. 
|
|
@gmartina thanks for your contribution. Looks good! |
3 participants
New Features
Tests converted to OSVVM:
Changes
Documentation
Tests
Related Issues and Pull-Requests