Potential fixes for 2 code quality findings

[daedaevibin]

This PR applies 2/2 suggestions from code quality AI findings.

Summary by CodeRabbit

• Documentation
  • Updated internal code comments for clarity.

---

Note: This release contains no user-facing changes.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f7bcf833-5e30-48a6-a3ed-da5d6e407a07

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• ✅ Review completed - (🔄 Check again to review again)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ai-findings-autofix/app-src-main-java-com-theveloper-pixelplay-data-repository-LyricsRepositoryImpl.kt

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/src/main/java/com/theveloper/pixelplay/data/repository/LyricsRepositoryImpl.kt (1)

1686-1693: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Comment is accurate but reveals separator handling inconsistency.

The comment correctly identifies \uFF0D as the fullwidth hyphen-minus, but there's an inconsistency in how it's handled:

• Line 1687 strips \uFF0D from the beginning of titles
• Line 1692's splitRegex splits on ASCII - but not on \uFF0D
• Meanwhile, TITLE_SEPARATOR_REGEX (line 138) and the aggressive fallback (line 537) both treat \uFF0D as a separator

Example: A title like "Song１－Remix" (with fullwidth hyphen in the middle) won't be split/truncated at the fullwidth hyphen, but "Song１-Remix" (ASCII hyphen) would be split to "Song１".

This inconsistency could affect search matching for CJK titles that use fullwidth punctuation.

🔧 Suggested fix

Add \uFF0D to the splitRegex on line 1692 to align with other separator handling:

-        val splitRegex = Regex("""[-\(\[\{\uFF08\uFF3B\uFF5B\u3010\u300E\u300C\u3014\u3008\u300A]""")
+        val splitRegex = Regex("""[-\uFF0D\(\[\{\uFF08\uFF3B\uFF5B\u3010\u300E\u300C\u3014\u3008\u300A]""")

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@app/src/main/java/com/theveloper/pixelplay/data/repository/LyricsRepositoryImpl.kt`
around lines 1686 - 1693, The split/truncate logic in LyricsRepositoryImpl.kt is
inconsistent: the leading-strip regex includes the fullwidth hyphen \uFF0D but
the splitRegex used to truncate (variable splitRegex) does not, causing titles
like "Song１－Remix" to not be split; update the splitRegex (the Regex assigned to
variable splitRegex near the truncation code) to include \uFF0D in its character
class so it matches fullwidth hyphens the same way as TITLE_SEPARATOR_REGEX and
the aggressive fallback.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In
`@app/src/main/java/com/theveloper/pixelplay/data/repository/LyricsRepositoryImpl.kt`:
- Around line 1686-1693: The split/truncate logic in LyricsRepositoryImpl.kt is
inconsistent: the leading-strip regex includes the fullwidth hyphen \uFF0D but
the splitRegex used to truncate (variable splitRegex) does not, causing titles
like "Song１－Remix" to not be split; update the splitRegex (the Regex assigned to
variable splitRegex near the truncation code) to include \uFF0D in its character
class so it matches fullwidth hyphens the same way as TITLE_SEPARATOR_REGEX and
the aggressive fallback.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e3a96395-776d-4fd5-a42b-4ca650f65fc9

📥 Commits

Reviewing files that changed from the base of the PR and between 874b523 and d435cc7.

📒 Files selected for processing (1)

• app/src/main/java/com/theveloper/pixelplay/data/repository/LyricsRepositoryImpl.kt