Skip to content

Potential fixes for 2 code quality findings #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daedaevibin merged 2 commits into from
Jun 11, 2026
Merged

Potential fixes for 2 code quality findings #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68fbd5d
Apply suggested fix to app/src/main/java/com/theveloper/pixelplay/dat…
daedaevibin Jun 11, 2026
d435cc7
Apply suggested fix to app/src/main/java/com/theveloper/pixelplay/dat…
daedaevibin Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/java/com/theveloper/pixelplay/data/repository/LyricsRepositoryImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,7 @@ class LyricsRepositoryImpl @Inject constructor(

// Strategy 4: Aggressive fallback - remove artist and trim title at separators
if (results.isEmpty()) {
// Include common CJK/Unicode separators: \uFF0D (fullwidth hyphen-minus), \u00B7 (middle dot), \u30FB (katakana middle dot)
val separators = charArrayOf('-', ',', '(', ')', '$', '#', ':', '%', '\uFF0D', '\u00B7', '\u30FB')
val index = cleanTitle.indexOfAny(separators)
if (index != -1) {
Expand Down Expand Up @@ -1682,6 +1683,7 @@ class LyricsRepositoryImpl @Inject constructor(

private fun cleanTitleSmart(title: String): String {
// 1. Remove leading digits/spaces/dots/hyphens (e.g., "01 ", "01. ", "01 - ")
// \uFF0D is the fullwidth hyphen-minus character used in fullwidth/CJK text.
var cleaned = title.replace(Regex("^[\\d\\s.\\-\\uFF0D]+"), "")

// 2. Truncate at first special char (-, (, ), Asian brackets)
Expand Down
Loading