Add unit tests for hide comment bulk action dropdown based on user capability #8264
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| if ( ! current_user_can( 'moderate_comments' ) ) { | ||
| return array(); // Return an empty array if the user doesn't have permission | ||
| } | ||
|
|
||
| $actions = array(); |
There was a problem hiding this comment.
| if ( ! current_user_can( 'moderate_comments' ) ) { | |
| return array(); // Return an empty array if the user doesn't have permission | |
| } | |
| $actions = array(); | |
| $actions = array(); | |
| if ( ! current_user_can( 'moderate_comments' ) ) { | |
| return $actions; | |
| } |
Simplify.
|
|
||
| wp_set_current_user( $u ); | ||
|
|
||
| $this->assertTrue( current_user_can( 'moderate_comments' ) ); |
There was a problem hiding this comment.
This assertion is probably a bit pointless here.
| ob_start(); | ||
| $this->table->bulk_actions(); | ||
| $output = ob_get_clean(); |
There was a problem hiding this comment.
You can use the get_echo helper function in tests.
|
|
||
| wp_set_current_user( $u ); | ||
|
|
||
| $this->assertFalse( current_user_can( 'moderate_comments' ) ); |
There was a problem hiding this comment.
This assertion is probably a bit pointless here.
| ob_start(); | ||
| $this->table->bulk_actions(); | ||
| $output = ob_get_clean(); |
| public function test_bulk_action_menu_should_not_be_shown_if_user_has_no_capability() { | ||
| $u = self::factory()->user->create_and_get( | ||
| array( | ||
| 'role' => 'subscriber', |
There was a problem hiding this comment.
Maybe author is a better choice here, a bit more realistic.
|
@jigneshnakrani088 Please fix the PHPCS issues and feedbacks. |
Trac ticket: https://core.trac.wordpress.org/ticket/59440
Added detailed PHPUnit tests to show bulk action drop-down menu for comments table list based on user capability.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.