Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PDLL] change abs to math_abs #174

Merged
merged 1 commit into from
May 7, 2024
Merged

[PDLL] change abs to math_abs #174

merged 1 commit into from
May 7, 2024

Conversation

ge28boj
Copy link

@ge28boj ge28boj commented May 6, 2024 •
edited
Loading

No description provided.

@ge28boj ge28boj requested review from ttjost and flemairen6 May 6, 2024 09:32
flemairen6
flemairen6 approved these changes May 6, 2024
View reviewed changes
Copy link

@flemairen6 flemairen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ttjost
ttjost approved these changes May 7, 2024
View reviewed changes
Copy link

@ttjost ttjost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Talked offline so that we later work on parsing properly keywords that have different meaning according to their usage. Approved to unblock llvm-project update.

@ttjost ttjost merged commit f4b3d1b into feature/fused-ops May 7, 2024
4 checks passed
@ttjost ttjost deleted the liangta.change_abs_name_in_pdll branch May 7, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttjost ttjost ttjost approved these changes

@flemairen6 flemairen6 flemairen6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ge28boj @ttjost @flemairen6