Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDLL] change abs to math_abs #174

Merged
merged 1 commit into from
May 7, 2024
Merged

[PDLL] change abs to math_abs #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/lib/Tools/PDLL/Parser/Lexer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ Token Lexer::lexIdentifier(const char *tokStart) {
.Case("_", Token::underscore)
.Case("log2", Token::log2)
.Case("exp2", Token::exp2)
.Case("abs", Token::abs)
.Case("math_abs", Token::abs)
.Default(Token::identifier);
return Token(kind, str);
}
Expand Down
4 changes: 2 additions & 2 deletions mlir/test/mlir-pdll/CodeGen/MLIR/expr.pdll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ Pattern TestOperatorsNotInRewriteSection {
let modConstraint : Attr = a % b;
let log2Constraint : Attr = log2(a);
let exp2Constraint : Attr = exp2(a);
let absConstraint : Attr = abs(a);
let absConstraint : Attr = math_abs(a);
replace op<test.simple> with op<test.success>;
}

Expand Down Expand Up @@ -351,7 +351,7 @@ Pattern TestOperatorsInRewriteSection {
let modRewrite : Attr = a % b;
let log2Rewrite : Attr = log2(a);
let exp2Rewrite : Attr = exp2(a);
let absRewrite : Attr = abs(a);
let absRewrite : Attr = math_abs(a);
erase root;
};
}
Expand Down
4 changes: 2 additions & 2 deletions mlir/test/mlir-pdll/Parser/expr-failure.pdll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ Pattern {
// CHECK: cannot evaluate abs operator in rewrite section. Assign to a variable with `let`
let root = op<>(operand: Value, operands: ValueRange) -> (type: Type, types: TypeRange);
rewrite root with {
abs(attr<"-4 : si32">);
math_abs(attr<"-4 : si32">);
erase root;
};
}
Expand Down Expand Up @@ -624,7 +624,7 @@ Pattern {
let root = op<>(operand: Value, operands: ValueRange) -> (type: Type, types: TypeRange);
rewrite root with {
let a : Attr = attr<"4 : i32"> + attr<"5 : i32">;
abs(attr<"4 : i32">);
math_abs(attr<"4 : i32">);
erase root;
};
}
12 changes: 6 additions & 6 deletions mlir/test/mlir-pdll/Parser/expr.pdll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ Pattern {
let modConstraint : Attr = a % b;
let log2Constraint : Attr = log2(a);
let exp2Constraint : Attr = exp2(b);
let absConstraint : Attr = abs(attr<"-4 : si32">);
let absConstraint : Attr = math_abs(attr<"-4 : si32">);
rewrite root with {
let addRewrite : Attr = attr<"4 : i32"> + attr<"5 : i32">;
let subRewrite : Attr = attr<"4 : i32"> - attr<"5 : i32">;
Expand All @@ -479,7 +479,7 @@ Pattern {
let modRewrite : Attr = attr<"4 : i32"> % attr<"5 : i32">;
let log2Rewrite : Attr = log2(attr<"4 : i32">);
let exp2Rewrite : Attr = exp2(attr<"4 : i32">);
let absRewrite : Attr = abs(attr<"-4 : si32">);
let absRewrite : Attr = math_abs(attr<"-4 : si32">);
erase root;
};
}
Expand Down Expand Up @@ -513,7 +513,7 @@ Constraint TestConstraint(attr: Attr, op: Op, type: Type, value: Value, typeRang
let modConstraint : Attr = a % b;
let log2Constraint : Attr = log2(a);
let exp2Constraint : Attr = exp2(b);
let absConstraint : Attr = abs(attr<"-4 : si32">);
let absConstraint : Attr = math_abs(attr<"-4 : si32">);
}

Rewrite TestRewrite(attr: Attr, op: Op, type: Type, value: Value, typeRange: TypeRange, valueRange: ValueRange) {
Expand All @@ -526,7 +526,7 @@ Rewrite TestRewrite(attr: Attr, op: Op, type: Type, value: Value, typeRange: Typ
let modRewrite : Attr = c % d;
let log2Rewrite : Attr = log2(c);
let exp2Rewrite : Attr = exp2(d);
let absRewrite : Attr = abs(attr<"-4 : si32">);
let absRewrite : Attr = math_abs(attr<"-4 : si32">);
}

Pattern TestOperatorContext {
Expand All @@ -552,7 +552,7 @@ Pattern TestOperatorContext {
Pattern {
let log2Constraint : Attr = log2(attr<"4 : i32"> + attr<"4 : i32">);
let exp2Constraint : Attr = exp2(attr<"2 : i32"> + attr<"2 : i32">);
let absConstraint : Attr = abs(attr<"-4 : si32"> + attr<"-2 : si32">);
let absConstraint : Attr = math_abs(attr<"-4 : si32"> + attr<"-2 : si32">);
erase _: Op;
}

Expand All @@ -576,7 +576,7 @@ Pattern {
attr<"4 : i32"> % attr<"5 : i32">;
log2(attr<"4 : i32">);
exp2(attr<"4 : i32">);
abs(attr<"-4 : si32">);
math_abs(attr<"-4 : si32">);
erase _: Op;
}

Expand Down