Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir] [TOSA] Allow any floating point type #175

Merged
merged 2 commits into from
May 7, 2024

Conversation

mgehre-amd
Copy link
Collaborator

This backports [TOSA] Allow all integer types in most ops from upstream
and on top also allows all floating point types (notably f64 and various 8-bit float types).

mgehre-amd added 2 commits May 6, 2024 13:27
As discussed in one of the previous TOSA community meetings, we would
like to allow for more integer types in the TOSA dialect to enable more
use cases.

For strict standards conformance, the TosaValidation pass can be used.

Follow up PRs will extend conversions from TOSA where needed.
@mgehre-amd mgehre-amd requested review from TinaAMD and josel-amd May 6, 2024 11:29
@TinaAMD
Copy link

TinaAMD commented May 6, 2024

Will allowing all floating point types stay local to our fork or was this also accepted by the Tosa community?

@mgehre-amd
Copy link
Collaborator Author

Will allowing all floating point types stay local to our fork or was this also accepted by the Tosa community?

This was accepted at the community meeting by Eric, so I expect it to land upstream like my PR for [TOSA] Allow all integer types in most ops did.

Copy link

@TinaAMD TinaAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgehre-amd mgehre-amd merged commit 719fc84 into feature/fused-ops May 7, 2024
4 checks passed
@mgehre-amd mgehre-amd deleted the matthias.any_float branch May 7, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants