Skip to content

Commit

Permalink
app core config panel: rework description/help for the force-upgrade …
Browse files Browse the repository at this point in the history
…button now that webadmin support help for buttons
  • Loading branch information
alexAubin committed Feb 24, 2025
1 parent 45df8b6 commit 78baa3b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"app_config_change_url_path": "New path",
"app_config_change_url_unsupported_msg": "Changing the URL where this app is installed is not currently supported for this app.",
"app_config_force_upgrade": "Force-upgrade",
"app_config_force_upgrade_explain": "Force-upgrading the app (to the same version) can sometime be useful to rebuild the app and configurations",
"app_config_force_upgrade_help": "Force-upgrading the app (to the same version) can sometime be useful to rebuild the app and configurations",
"app_config_operations_name": "Operations",
"app_config_permission_allowed": "Groups/users allowed to access",
"app_config_permission_allowed_warn_protected": "NB: this permission is 'protected' and therefore the 'visitors' group cannot be actually added/removed from the authorized groups.",
Expand Down
1 change: 1 addition & 0 deletions maintenance/missing_i18n_keys.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ def find_expected_string_keys():
app_settings_with_help_key = [
"logo",
"description",
"force_upgrade",
]
for panel_key, panel in app_config.items():
if not isinstance(panel, dict):
Expand Down
4 changes: 0 additions & 4 deletions share/config_app.toml
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ i18n = "app_config"
style = "success"
visible = "upgradable == 'yes'"

[_core.operations.force_upgrade_explain]
type = "markdown"
visible = "upgradable == 'no'"

[_core.operations.force_upgrade]
type = "button"
icon = "refresh"
Expand Down

0 comments on commit 78baa3b

Please sign in to comment.