Skip to content
This repository was archived by the owner on Aug 16, 2023. It is now read-only.

Conversation

@graingert
Copy link

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 15, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.29%.

Quality metrics Before After Change
Complexity 2.59 ⭐ 2.62 ⭐ 0.03 👎
Method Length 31.84 ⭐ 32.54 ⭐ 0.70 👎
Working memory 5.05 ⭐ 5.13 ⭐ 0.08 👎
Quality 84.34% 84.05% -0.29% 👎
Other metrics Before After Change
Lines 646 660 14
Changed files Quality Before Quality After Quality Change
starlette_core/database.py 82.86% ⭐ 82.86% ⭐ 0.00%
starlette_core/templating.py 83.66% ⭐ 84.16% ⭐ 0.50% 👍
starlette_core/mail/init.py 84.70% ⭐ 84.70% ⭐ 0.00%
starlette_core/mail/backends/console.py 83.09% ⭐ 83.09% ⭐ 0.00%
starlette_core/mail/backends/smtp.py 80.12% ⭐ 80.12% ⭐ 0.00%
tests/test_database.py 86.31% ⭐ 85.85% ⭐ -0.46% 👎
tests/test_messages.py 95.48% ⭐ 93.21% ⭐ -2.27% 👎
tests/test_middleware.py 88.35% ⭐ 86.83% ⭐ -1.52% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
starlette_core/database.py DatabaseURL.replace 15 🙂 178 😞 10 😞 46.14% 😞 Try splitting into smaller methods. Extract out complex expressions
starlette_core/mail/backends/smtp.py EmailBackend.__init__ 6 ⭐ 78 🙂 11 😞 64.32% 🙂 Extract out complex expressions
tests/test_database.py test_declarative_base__can_be_deleted 0 ⭐ 164 😞 6 ⭐ 70.59% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant