fix(newsletter): allow drafts to send immediately - #6659
Merged
Conversation
Contributor
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — operational newsletter delivery fix; no blocking findings.
What I checked:
- Scope is server/admin/newsletter/digest only — no
static/schemas/source/**,docs/reference/**,dist/**, or other published protocol surface. No changeset required (correctly identified as operational-only). - No schema↔docs coherence, oneOf discriminator, released-artifact immutability, or governance-precedent concerns apply — the diff does not touch the protocol surface.
high_riskis true only becauseserver/src/addie/jobs/weekly-digest.tsmatchesserver/src/addie/**, but the change-kind is(modified)and the reviewer found no medium-or-higher concern on it. Presumed safe per the high-risk-flag rules.- Both reviewer findings are
low(Slack "Delivery failed" copy on lock contention; long-held advisory lock without timeout) — omitted from blocking analysis. - Advisory-lock wrapper serializes all three send paths with matching keys, re-reads and ships only approved rows under the lock (closes double-send window), fail-closed, well-tested.
Decision table: No critical/high findings (row 1 no). gated_paths: false (row 2 no). No (deleted) high-risk reason (row 3 no). No medium findings at all (rows 4, 5, 8 no). No prior escalate (row 6 no). No no-auto-approve team match (row 7 no). Falls through to row 9 → approve.
Note: review_decision is REVIEW_REQUIRED, but gated_paths is false and no prose hard-gate (spec ownership, breaking-class change, major-version bump) applies to this server-only operational diff, so the required-review status does not force escalation.
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6532
Validation
npm run precommit