Mwpw 170384 lost info 320 #3881
Conversation
libs/styles/iframe.css
Outdated
| @@ -1,3 +1,7 @@ | |||
| :root { | |||
| --iframe-video-aspect-ratio: 0.5625; | |||
There was a problem hiding this comment.
I'm a bit reluctant to assume a 16:9 aspect ratio for all videos inside modals. We have 9:16 videos (which seem to be covered by the tall-video modal metadata style), square videos, etc. What would be the outcome for other aspect ratios? A modal larger than the video? Or would it have any other effect?
There was a problem hiding this comment.
I added the tall-video example, on normal size screens it behaves the same because tall-video overrides my css.
For square videos I assume they will behave the same as 16:9 behaves on ultra wide screen
Modal gets wider than the video when it hits max-height.
I did notice that tall video gets an overflow on zoom bigger than 250% - 300% and also has bigger height on ultra wide screens ( and overflow on zoom)
I will look into tall-video issues that I found.
If you have a link to the example of the square video, that would be nice so I can check the exact behavior.
There was a problem hiding this comment.
I don't have a prod example, but I generated something quickly with Express, so you can use it on a page 😅
Square.Video.mp4
There was a problem hiding this comment.
For square videos it will be the same way as for wide videos on ultra wide screen, modal becomes bigger then the video and MPC fills it with background.
|
Reminder to set the |
Resolves: MWPW-170384
Test overflow by zooming in the page or on very wide screen.
Chat button is only present on CC page.
Test URLs:
Example CC page from the ticket