Apply Version Updates From Current Changes - #13
Conversation
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
📝 WalkthroughWalkthroughThis patch release updates multiple Tauri crates with version bumps and dependency upgrades. The tauri-macos-sign crate introduces a breaking change by exporting a custom Error enum instead of using anyhow. Docs.rs build failures are resolved across several crates, and changelog entries document these changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
crates/tauri-macos-sign/src/lib.rs (2)
232-246:⚠️ Potential issue | 🟠 MajorPotential logic error in notarization status handling when not waiting.
The condition
submit_output.status.map_or(wait, |s| s == "Accepted")has the following behavior:
waitstatusResult Expected trueNonetrue(success)Should require "Accepted" true"Accepted"true(success)✓ falseNonefalse(error)Should succeed (per comment on line 232) false"Accepted"true(success)✓ Per the comment "status is empty when not waiting", when
wait=falsethe status is typicallyNone. With this logic, the code would fall into the error branch and attempt to fetch the notarytool log, rather than printing the "Not waiting for notarization to finish" messages.Consider whether the condition should be
map_or(!wait, |s| s == "Accepted")to handle the non-waiting case correctly.🐛 Suggested fix
// status is empty when not waiting for the notarization to finish - if submit_output.status.map_or(wait, |s| s == "Accepted") { + if submit_output.status.map_or(!wait, |s| s == "Accepted") { println!("Notarizing {log_message}");
168-179:⚠️ Potential issue | 🔴 CriticalFix
dittoargument order: source must come before destination zip.The
ditto -c -kcommand for creating PKZip archives requires<src> <dst.zip>order. The current code has these reversed—zip_path(the destination archive) is placed beforeapp_bundle_path(the source directory). This will cause the command to fail.Correct order:
-c -k --keepParent --sequesterRsrc app_bundle_path zip_path
🤖 Fix all issues with AI agents
In `@crates/tauri-build/CHANGELOG.md`:
- Around line 5-8: Update the changelog entry text "No user facing changes." to
hyphenate the adjective by changing it to "No user-facing changes." — locate the
string in the entry referencing commit 4b6b8690a / PR `#14347` and replace the
unhyphenated phrase with the hyphenated form.
In `@crates/tauri-macos-sign/CHANGELOG.md`:
- Around line 3-7: The CHANGELOG entry contains a bare URL
"https://github.com/tauri-apps/tauri/pull/14126" which violates markdownlint
MD034; update the line in the 2.3.0 Enhancements block to wrap that URL in
explicit link syntax (e.g., [PR
`#14126`](https://github.com/tauri-apps/tauri/pull/14126) or similar) so the URL
is not bare while preserving the existing text and reference to the PR/commit.
In `@crates/tauri-macos-sign/src/lib.rs`:
- Line 20: Remove the unused thiserror dependency from Cargo.toml: open
Cargo.toml and delete the thiserror entry from [dependencies] (or move it to
[dev-dependencies] only if still used in tests), since the crate no longer
derives Error with thiserror and the Error enum in lib.rs implements Display and
std::error::Error manually; ensure Cargo.lock / cargo build succeeds after
removing the entry to verify no remaining references to thiserror exist.
In `@crates/tauri-plugin/CHANGELOG.md`:
- Line 7: Update the changelog entry text to hyphenate the compound adjective
"user facing" to "user-facing" in the line containing the commit reference
`4b6b8690a` (the entry starting "Fixed an issue that caused docs.rs builds to
fail. No user facing changes."); edit that sentence so it reads "No user-facing
changes."
🧹 Nitpick comments (1)
crates/tauri-macos-sign/src/lib.rs (1)
80-90: Incompletesource()coverage may affect error chain introspection.The
source()implementation only returns the underlying error for 4 variants (TempDir,FailedToUploadApp,CommandFailed,Fs), but several other variants also wrap errors that could be exposed:
Plist { error, .. }wrapsplist::ErrorX509Certificate { error }wrapsX509CertificateErrorFailedToCreateSelfSignedCertificate { error }wrapsAppleCodesignErrorFailedToEncodeDER { error }wrapsstd::io::ErrorIf error chain introspection is important for debugging or logging, consider exposing these sources as well.
♻️ Suggested enhancement for complete source coverage
impl std::error::Error for Error { fn source(&self) -> Option<&(dyn std::error::Error + 'static)> { match self { Error::TempDir(e) => Some(e), Error::FailedToUploadApp { error } => Some(error), Error::CommandFailed { error, .. } => Some(error), Error::Fs { error, .. } => Some(error), + Error::Plist { error, .. } => Some(error), + Error::X509Certificate { error } => Some(error), + Error::FailedToCreateSelfSignedCertificate { error } => Some(error.as_ref()), + Error::FailedToEncodeDER { error } => Some(error), _ => None, } } }
| ### Bug Fixes | ||
|
|
||
| - [`4b6b8690a`](https://www.github.com/tauri-apps/tauri/commit/4b6b8690ab886ebdf1307951cffbe03e31280baa) ([#14347](https://www.github.com/tauri-apps/tauri/pull/14347) by [@FabianLars](https://www.github.com/tauri-apps/tauri/../../FabianLars)) Fixed an issue that caused docs.rs builds to fail. No user facing changes. | ||
|
|
There was a problem hiding this comment.
Hyphenate “user-facing”.
Minor grammar polish in the new entry.
✍️ Suggested edit
- Fixed an issue that caused docs.rs builds to fail. No user facing changes.
+ Fixed an issue that caused docs.rs builds to fail. No user-facing changes.🧰 Tools
🪛 LanguageTool
[style] ~7-~7: Consider using a different verb for a more formal wording.
Context: ...com/tauri-apps/tauri/../../FabianLars)) Fixed an issue that caused docs.rs builds to ...
(FIX_RESOLVE)
[grammar] ~7-~7: Use a hyphen to join words.
Context: ...t caused docs.rs builds to fail. No user facing changes. ## [2.5.0] ### New Fe...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
In `@crates/tauri-build/CHANGELOG.md` around lines 5 - 8, Update the changelog
entry text "No user facing changes." to hyphenate the adjective by changing it
to "No user-facing changes." — locate the string in the entry referencing commit
4b6b8690a / PR `#14347` and replace the unhyphenated phrase with the hyphenated
form.
| ## \[2.3.0] | ||
|
|
||
| ### Enhancements | ||
|
|
||
| - [`f59bf9d53`](https://www.github.com/tauri-apps/tauri/commit/f59bf9d5392ffd209e26ce5259c26d1acc31c4ba) ([#14337](https://www.github.com/tauri-apps/tauri/pull/14337) by [@FabianLars](https://www.github.com/tauri-apps/tauri/../../FabianLars)) **Potentially breaking change:** Export custom Error enum instead of using anyhow. The changes happened in https://github.com/tauri-apps/tauri/pull/14126. |
There was a problem hiding this comment.
Fix bare URL to satisfy markdownlint (MD034).
Line 7 includes a bare URL; wrap it in link syntax.
📝 Suggested fix
-- [`f59bf9d53`](https://www.github.com/tauri-apps/tauri/commit/f59bf9d5392ffd209e26ce5259c26d1acc31c4ba) ([`#14337`](https://www.github.com/tauri-apps/tauri/pull/14337) by [`@FabianLars`](https://www.github.com/tauri-apps/tauri/../../FabianLars)) **Potentially breaking change:** Export custom Error enum instead of using anyhow. The changes happened in https://github.com/tauri-apps/tauri/pull/14126.
+- [`f59bf9d53`](https://www.github.com/tauri-apps/tauri/commit/f59bf9d5392ffd209e26ce5259c26d1acc31c4ba) ([`#14337`](https://www.github.com/tauri-apps/tauri/pull/14337) by [`@FabianLars`](https://www.github.com/tauri-apps/tauri/../../FabianLars)) **Potentially breaking change:** Export custom Error enum instead of using anyhow. The changes happened in [`#14126`](https://github.com/tauri-apps/tauri/pull/14126).🧰 Tools
🪛 markdownlint-cli2 (0.20.0)
[warning] 7-7: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In `@crates/tauri-macos-sign/CHANGELOG.md` around lines 3 - 7, The CHANGELOG entry
contains a bare URL "https://github.com/tauri-apps/tauri/pull/14126" which
violates markdownlint MD034; update the line in the 2.3.0 Enhancements block to
wrap that URL in explicit link syntax (e.g., [PR
`#14126`](https://github.com/tauri-apps/tauri/pull/14126) or similar) so the URL
is not bare while preserving the existing text and reference to the PR/commit.
| pub use provisioning_profile::ProvisioningProfile; | ||
|
|
||
| #[derive(Debug, thiserror::Error)] | ||
| #[derive(Debug)] |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if thiserror is used anywhere in the tauri-macos-sign crate
rg -n "thiserror" crates/tauri-macos-sign/Repository: agentic-review-benchmarks/tauri-combined-coderabbit
Length of output: 148
🏁 Script executed:
#!/bin/bash
# Also check the Cargo.toml to see if thiserror is listed as a dependency
cat crates/tauri-macos-sign/Cargo.toml | grep -A 5 -B 5 "thiserror"Repository: agentic-review-benchmarks/tauri-combined-coderabbit
Length of output: 360
🏁 Script executed:
#!/bin/bash
# Check if there are any use statements or imports of thiserror
rg -n "use.*thiserror|from.*thiserror|thiserror::" crates/tauri-macos-sign/Repository: agentic-review-benchmarks/tauri-combined-coderabbit
Length of output: 77
Remove the unused thiserror dependency from Cargo.toml.
The thiserror crate is listed in Cargo.toml but is no longer used in the crate since the Error enum now uses manual Display and std::error::Error implementations instead of the thiserror derive macro. Remove it from the dependencies to eliminate unnecessary bloat.
🤖 Prompt for AI Agents
In `@crates/tauri-macos-sign/src/lib.rs` at line 20, Remove the unused thiserror
dependency from Cargo.toml: open Cargo.toml and delete the thiserror entry from
[dependencies] (or move it to [dev-dependencies] only if still used in tests),
since the crate no longer derives Error with thiserror and the Error enum in
lib.rs implements Display and std::error::Error manually; ensure Cargo.lock /
cargo build succeeds after removing the entry to verify no remaining references
to thiserror exist.
|
|
||
| ### Bug Fixes | ||
|
|
||
| - [`4b6b8690a`](https://www.github.com/tauri-apps/tauri/commit/4b6b8690ab886ebdf1307951cffbe03e31280baa) ([#14347](https://www.github.com/tauri-apps/tauri/pull/14347) by [@FabianLars](https://www.github.com/tauri-apps/tauri/../../FabianLars)) Fixed an issue that caused docs.rs builds to fail. No user facing changes. |
There was a problem hiding this comment.
Hyphenate “user-facing”.
Compound adjective should be hyphenated.
✏️ Proposed fix
-... Fixed an issue that caused docs.rs builds to fail. No user facing changes.
+... Fixed an issue that caused docs.rs builds to fail. No user-facing changes.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - [`4b6b8690a`](https://www.github.com/tauri-apps/tauri/commit/4b6b8690ab886ebdf1307951cffbe03e31280baa) ([#14347](https://www.github.com/tauri-apps/tauri/pull/14347) by [@FabianLars](https://www.github.com/tauri-apps/tauri/../../FabianLars)) Fixed an issue that caused docs.rs builds to fail. No user facing changes. | |
| - [`4b6b8690a`](https://www.github.com/tauri-apps/tauri/commit/4b6b8690ab886ebdf1307951cffbe03e31280baa) ([`#14347`](https://www.github.com/tauri-apps/tauri/pull/14347) by [`@FabianLars`](https://www.github.com/tauri-apps/tauri/../../FabianLars)) Fixed an issue that caused docs.rs builds to fail. No user-facing changes. |
🧰 Tools
🪛 LanguageTool
[style] ~7-~7: Consider using a different verb for a more formal wording.
Context: ...com/tauri-apps/tauri/../../FabianLars)) Fixed an issue that caused docs.rs builds to ...
(FIX_RESOLVE)
[grammar] ~7-~7: Use a hyphen to join words.
Context: ...t caused docs.rs builds to fail. No user facing changes. ## [2.5.0] ### Depend...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
In `@crates/tauri-plugin/CHANGELOG.md` at line 7, Update the changelog entry text
to hyphenate the compound adjective "user facing" to "user-facing" in the line
containing the commit reference `4b6b8690a` (the entry starting "Fixed an issue
that caused docs.rs builds to fail. No user facing changes."); edit that
sentence so it reads "No user-facing changes."
1 participant
Benchmark PR from agentic-review-benchmarks#13
Summary by CodeRabbit
Release Notes
Bug Fixes
Chores