-
Notifications
You must be signed in to change notification settings - Fork 0
Apply Version Updates From Current Changes #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: coderabbit_full_base_apply_version_updates_from_current_changes_pr13
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| # Changelog | ||
|
|
||
| ## \[2.7.1] | ||
|
|
||
| ### Dependencies | ||
|
|
||
| - Upgraded to `tauri-macos-sign@2.3.0` | ||
|
|
||
| ## \[2.7.0] | ||
|
|
||
| ### New Features | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| { | ||
| "cli.js": { | ||
| "version": "2.9.0", | ||
| "version": "2.9.1", | ||
| "node": ">= 10.0.0" | ||
| }, | ||
| "tauri": "2.9.0", | ||
| "tauri-build": "2.5.0", | ||
| "tauri-plugin": "2.5.0" | ||
| "tauri": "2.9.1", | ||
| "tauri-build": "2.5.1", | ||
| "tauri-plugin": "2.5.1" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| # Changelog | ||
|
|
||
| ## \[2.3.0] | ||
|
|
||
| ### Enhancements | ||
|
|
||
| - [`f59bf9d53`](https://www.github.com/tauri-apps/tauri/commit/f59bf9d5392ffd209e26ce5259c26d1acc31c4ba) ([#14337](https://www.github.com/tauri-apps/tauri/pull/14337) by [@FabianLars](https://www.github.com/tauri-apps/tauri/../../FabianLars)) **Potentially breaking change:** Export custom Error enum instead of using anyhow. The changes happened in https://github.com/tauri-apps/tauri/pull/14126. | ||
|
Comment on lines
+3
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix bare URL to satisfy markdownlint (MD034). Line 7 includes a bare URL; wrap it in link syntax. 📝 Suggested fix-- [`f59bf9d53`](https://www.github.com/tauri-apps/tauri/commit/f59bf9d5392ffd209e26ce5259c26d1acc31c4ba) ([`#14337`](https://www.github.com/tauri-apps/tauri/pull/14337) by [`@FabianLars`](https://www.github.com/tauri-apps/tauri/../../FabianLars)) **Potentially breaking change:** Export custom Error enum instead of using anyhow. The changes happened in https://github.com/tauri-apps/tauri/pull/14126.
+- [`f59bf9d53`](https://www.github.com/tauri-apps/tauri/commit/f59bf9d5392ffd209e26ce5259c26d1acc31c4ba) ([`#14337`](https://www.github.com/tauri-apps/tauri/pull/14337) by [`@FabianLars`](https://www.github.com/tauri-apps/tauri/../../FabianLars)) **Potentially breaking change:** Export custom Error enum instead of using anyhow. The changes happened in [`#14126`](https://github.com/tauri-apps/tauri/pull/14126).🧰 Tools🪛 markdownlint-cli2 (0.20.0)[warning] 7-7: Bare URL used (MD034, no-bare-urls) 🤖 Prompt for AI Agents |
||
|
|
||
| ## \[2.2.0] | ||
|
|
||
| ### New Features | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,59 +17,78 @@ mod provisioning_profile; | |
| pub use keychain::{Keychain, Team}; | ||
| pub use provisioning_profile::ProvisioningProfile; | ||
|
|
||
| #[derive(Debug, thiserror::Error)] | ||
| #[derive(Debug)] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check if thiserror is used anywhere in the tauri-macos-sign crate
rg -n "thiserror" crates/tauri-macos-sign/Repository: agentic-review-benchmarks/tauri-combined-coderabbit Length of output: 148 🏁 Script executed: #!/bin/bash
# Also check the Cargo.toml to see if thiserror is listed as a dependency
cat crates/tauri-macos-sign/Cargo.toml | grep -A 5 -B 5 "thiserror"Repository: agentic-review-benchmarks/tauri-combined-coderabbit Length of output: 360 🏁 Script executed: #!/bin/bash
# Check if there are any use statements or imports of thiserror
rg -n "use.*thiserror|from.*thiserror|thiserror::" crates/tauri-macos-sign/Repository: agentic-review-benchmarks/tauri-combined-coderabbit Length of output: 77 Remove the unused The 🤖 Prompt for AI Agents |
||
| pub enum Error { | ||
| #[error("failed to create temp directory: {0}")] | ||
| TempDir(std::io::Error), | ||
| #[error("failed to resolve home dir")] | ||
| ResolveHomeDir, | ||
| #[error("failed to resolve signing identity")] | ||
| ResolveSigningIdentity, | ||
| #[error("failed to decode provisioning profile")] | ||
| FailedToDecodeProvisioningProfile, | ||
| #[error("could not find provisioning profile UUID")] | ||
| FailedToFindProvisioningProfileUuid, | ||
| #[error("{context} {path}: {error}")] | ||
| Plist { | ||
| context: &'static str, | ||
| path: PathBuf, | ||
| error: plist::Error, | ||
| }, | ||
| #[error("failed to upload app to Apple's notarization servers: {error}")] | ||
| FailedToUploadApp { error: std::io::Error }, | ||
| #[error("failed to notarize app: {0}")] | ||
| Notarize(String), | ||
| #[error("failed to parse notarytool output as JSON: {output}")] | ||
| ParseNotarytoolOutput { output: String }, | ||
| #[error("failed to run command {command}: {error}")] | ||
| CommandFailed { | ||
| command: String, | ||
| error: std::io::Error, | ||
| }, | ||
| #[error("{context} {path}: {error}")] | ||
| Fs { | ||
| context: &'static str, | ||
| path: PathBuf, | ||
| error: std::io::Error, | ||
| }, | ||
| #[error("failed to parse X509 certificate: {error}")] | ||
| X509Certificate { | ||
| error: x509_certificate::X509CertificateError, | ||
| }, | ||
| #[error("failed to create PFX from self signed certificate")] | ||
| FailedToCreatePFX, | ||
| #[error("failed to create self signed certificate: {error}")] | ||
| FailedToCreateSelfSignedCertificate { | ||
| error: Box<apple_codesign::AppleCodesignError>, | ||
| }, | ||
| #[error("failed to encode DER: {error}")] | ||
| FailedToEncodeDER { error: std::io::Error }, | ||
| #[error("certificate missing common name")] | ||
| CertificateMissingCommonName, | ||
| #[error("certificate missing organization unit for common name {common_name}")] | ||
| CertificateMissingOrganizationUnit { common_name: String }, | ||
| } | ||
|
|
||
| impl std::fmt::Display for Error { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| match self { | ||
| Error::TempDir(e) => write!(f, "failed to create temp directory: {}", e), | ||
| Error::ResolveHomeDir => write!(f, "failed to resolve home dir"), | ||
| Error::ResolveSigningIdentity => write!(f, "failed to resolve signing identity"), | ||
| Error::FailedToDecodeProvisioningProfile => write!(f, "failed to decode provisioning profile"), | ||
| Error::FailedToFindProvisioningProfileUuid => write!(f, "could not find provisioning profile UUID"), | ||
| Error::Plist { context, path, error } => write!(f, "{} {}: {}", context, path.display(), error), | ||
| Error::FailedToUploadApp { error } => write!(f, "failed to upload app to Apple's notarization servers: {}", error), | ||
| Error::Notarize(msg) => write!(f, "failed to notarize app: {}", msg), | ||
| Error::ParseNotarytoolOutput { output } => write!(f, "failed to parse notarytool output as JSON: {}", output), | ||
| Error::CommandFailed { command, error } => write!(f, "failed to run command {}: {}", command, error), | ||
| Error::Fs { context, path, error } => write!(f, "{} {}: {}", context, path.display(), error), | ||
| Error::X509Certificate { error } => write!(f, "failed to parse X509 certificate: {}", error), | ||
| Error::FailedToCreatePFX => write!(f, "failed to create PFX from self signed certificate"), | ||
| Error::FailedToCreateSelfSignedCertificate { error } => write!(f, "failed to create self signed certificate: {}", error), | ||
| Error::FailedToEncodeDER { error } => write!(f, "failed to encode DER: {}", error), | ||
| Error::CertificateMissingCommonName => write!(f, "certificate missing common name"), | ||
| Error::CertificateMissingOrganizationUnit { common_name } => write!(f, "certificate missing organization unit for common name {}", common_name), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl std::error::Error for Error { | ||
| fn source(&self) -> Option<&(dyn std::error::Error + 'static)> { | ||
| match self { | ||
| Error::TempDir(e) => Some(e), | ||
| Error::FailedToUploadApp { error } => Some(error), | ||
| Error::CommandFailed { error, .. } => Some(error), | ||
| Error::Fs { error, .. } => Some(error), | ||
| _ => None, | ||
| } | ||
| } | ||
| } | ||
|
|
||
| pub type Result<T> = std::result::Result<T, Error>; | ||
|
|
||
| trait CommandExt { | ||
|
|
@@ -151,12 +170,12 @@ fn notarize_inner( | |
| "-k", | ||
| "--keepParent", | ||
| "--sequesterRsrc", | ||
| app_bundle_path | ||
| .to_str() | ||
| .expect("failed to convert bundle_path to string"), | ||
| zip_path | ||
| .to_str() | ||
| .expect("failed to convert zip_path to string"), | ||
| app_bundle_path | ||
| .to_str() | ||
| .expect("failed to convert bundle_path to string"), | ||
| ]; | ||
|
|
||
| // use ditto to create a PKZip almost identical to Finder | ||
|
|
@@ -211,7 +230,7 @@ fn notarize_inner( | |
| submit_output.message | ||
| ); | ||
| // status is empty when not waiting for the notarization to finish | ||
| if submit_output.status.map_or(!wait, |s| s == "Accepted") { | ||
| if submit_output.status.map_or(wait, |s| s == "Accepted") { | ||
| println!("Notarizing {log_message}"); | ||
|
|
||
| if wait { | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,5 +1,11 @@ | ||||||
| # Changelog | ||||||
|
|
||||||
| ## \[2.5.1] | ||||||
|
|
||||||
| ### Bug Fixes | ||||||
|
|
||||||
| - [`4b6b8690a`](https://www.github.com/tauri-apps/tauri/commit/4b6b8690ab886ebdf1307951cffbe03e31280baa) ([#14347](https://www.github.com/tauri-apps/tauri/pull/14347) by [@FabianLars](https://www.github.com/tauri-apps/tauri/../../FabianLars)) Fixed an issue that caused docs.rs builds to fail. No user facing changes. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hyphenate “user-facing”. Compound adjective should be hyphenated. ✏️ Proposed fix-... Fixed an issue that caused docs.rs builds to fail. No user facing changes.
+... Fixed an issue that caused docs.rs builds to fail. No user-facing changes.📝 Committable suggestion
Suggested change
🧰 Tools🪛 LanguageTool[style] ~7-~7: Consider using a different verb for a more formal wording. (FIX_RESOLVE) [grammar] ~7-~7: Use a hyphen to join words. (QB_NEW_EN_HYPHEN) 🤖 Prompt for AI Agents |
||||||
|
|
||||||
| ## \[2.5.0] | ||||||
|
|
||||||
| ### Dependencies | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyphenate “user-facing”.
Minor grammar polish in the new entry.
✍️ Suggested edit
🧰 Tools
🪛 LanguageTool
[style] ~7-~7: Consider using a different verb for a more formal wording.
Context: ...com/tauri-apps/tauri/../../FabianLars)) Fixed an issue that caused docs.rs builds to ...
(FIX_RESOLVE)
[grammar] ~7-~7: Use a hyphen to join words.
Context: ...t caused docs.rs builds to fail. No user facing changes. ## [2.5.0] ### New Fe...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents