Docker support and various fixes to get it working - #239
Open
adettori wants to merge 15 commits into
Open
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…example visualizations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I'm currently working on comparing some pose estimation methods and wanted to containerize happypose to avoid handling the system dependencies by hand.
Tried to keep the changes as small as possible, but let me know if there is something that could be done better (if you are interested in incorporating the changes ofc).
Sidenote: it seems that the some mirrors used in the toolbox.download script seem to reference files that are corrupted when running "python -m happypose.toolbox.utils.download --bop_dataset ycbv", I avoided touching the download script but instead included huggingface-hub in the dependencies and updated the instructions accordingly.
Looking forward to any feedback