Conversation
alxbilger
left a comment
There was a problem hiding this comment.
Could you make the seed fixed so that benchmarks are reproducible from a compilation to another?
|
@fredroy there is a conflict to solve. Also, could you check that the random numbers are always the same? |
same between what? |
|
That's what I mean. If you compile twice the benchmark you won't have the same numbers, so the benchmarks are not rigorously reproducible. If the seed is, let's say, 12, the numbers will stay the same between two compilations |
I see, so we should add a fixed seed or something like that |
|
Yes, we should be able to provide a seed to the random numbers generator. And in the benchmarks, use a constant seed. |
f0dd43e to
55e7787
Compare
Obviously, if the constexpr function compiles, then the result is instantaneous
+ add a constexpr random generator (from https://www.youtube.com/watch?v=rpn_5Mrrxf8 😎 of course)
This branch needs SOFA's Mat.h to be fixed, as std::abs is not constexpr (officially)