[Sofa.Type] Fix compile-time Mat and Vec#3281
Merged
damienmarchal merged 3 commits intosofa-framework:masterfrom Sep 21, 2022
Merged
[Sofa.Type] Fix compile-time Mat and Vec#3281damienmarchal merged 3 commits intosofa-framework:masterfrom
damienmarchal merged 3 commits intosofa-framework:masterfrom
Conversation
Contributor
Author
|
[ci-build][with-all-tests] |
alxbilger
reviewed
Sep 8, 2022
Contributor
Author
|
[ci-build][with-all-tests] |
1 similar comment
Contributor
|
[ci-build][with-all-tests] |
Contributor
|
Merge if CI pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::abs is constexpr only in c++23
-> as stated in the standard... But gcc flagged it constexpr 🤫
std::sqrt is not constexpr at all. Implementations exists though. For now, all functions relying on sqrt is not constexpr (norm methods)
Allows to compile alxbilger/SofaBenchmark#27 (for mac and msvc then)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if